CPP: Add a test case that we handle poorly.

Author: geoffw0

cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Linux_signed_chars/WrongTypeFormatArguments.expected

@@ -18,7 +18,9 @@
 | printf1.h:73:19:73:22 | c_st | This argument should be of type 'ssize_t' but is of type 'unsigned long' |
 | printf1.h:74:19:74:22 | C_ST | This argument should be of type 'ssize_t' but is of type 'unsigned long' |
 | printf1.h:75:19:75:28 | sizeof(<expr>) | This argument should be of type 'ssize_t' but is of type 'unsigned long' |
+| printf1.h:82:23:82:35 | ... - ... | This argument should be of type 'ptrdiff_t' but is of type 'long' |
 | printf1.h:83:23:83:35 | ... - ... | This argument should be of type 'size_t' but is of type 'long' |
+| printf1.h:102:19:102:21 | ... - ... | This argument should be of type 'ptrdiff_t' but is of type 'long' |
 | real_world.h:61:21:61:22 | & ... | This argument should be of type 'int *' but is of type 'short *' |
 | real_world.h:62:22:62:23 | & ... | This argument should be of type 'short *' but is of type 'int *' |
 | real_world.h:63:22:63:24 | & ... | This argument should be of type 'short *' but is of type 'unsigned int *' |

cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Linux_signed_chars/printf1.h

@@ -79,7 +79,7 @@ void g()
         char buf[100];
 
         printf("%tu", ptr_a - ptr_b); // ok
-        printf("%td", ptr_a - ptr_b); // ok
+        printf("%td", ptr_a - ptr_b); // ok [FALSE POSITIVE]
         printf("%zu", ptr_a - ptr_b); // ok (dubious) [DETECTED ON LINUX ONLY]
         printf("%zd", ptr_a - ptr_b); // ok (dubious) [DETECTED ON MICROSOFT ONLY]
     }
@@ -92,3 +92,12 @@ void h(int i, struct some_type *j, int k)
 	// going on.
 	printf("%i %R %i", i, j, k); // GOOD (as far as we can tell)
 }
+
+typedef long ptrdiff_t;
+
+void fun1(unsigned char* a, unsigned char* b) {
+  ptrdiff_t pdt;
+
+  printf("%td\n", pdt); // GOOD
+  printf("%td\n", a-b); // GOOD [FALSE POSITIVE]
+}

cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Linux_unsigned_chars/WrongTypeFormatArguments.expected

@@ -18,7 +18,9 @@
 | printf1.h:73:19:73:22 | c_st | This argument should be of type 'ssize_t' but is of type 'unsigned long' |
 | printf1.h:74:19:74:22 | C_ST | This argument should be of type 'ssize_t' but is of type 'unsigned long' |
 | printf1.h:75:19:75:28 | sizeof(<expr>) | This argument should be of type 'ssize_t' but is of type 'unsigned long' |
+| printf1.h:82:23:82:35 | ... - ... | This argument should be of type 'ptrdiff_t' but is of type 'long' |
 | printf1.h:83:23:83:35 | ... - ... | This argument should be of type 'size_t' but is of type 'long' |
+| printf1.h:102:19:102:21 | ... - ... | This argument should be of type 'ptrdiff_t' but is of type 'long' |
 | real_world.h:61:21:61:22 | & ... | This argument should be of type 'int *' but is of type 'short *' |
 | real_world.h:62:22:62:23 | & ... | This argument should be of type 'short *' but is of type 'int *' |
 | real_world.h:63:22:63:24 | & ... | This argument should be of type 'short *' but is of type 'unsigned int *' |

cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Linux_unsigned_chars/printf1.h

@@ -79,7 +79,7 @@ void g()
         char buf[100];
 
         printf("%tu", ptr_a - ptr_b); // ok
-        printf("%td", ptr_a - ptr_b); // ok
+        printf("%td", ptr_a - ptr_b); // ok [FALSE POSITIVE]
         printf("%zu", ptr_a - ptr_b); // ok (dubious) [DETECTED ON LINUX ONLY]
         printf("%zd", ptr_a - ptr_b); // ok (dubious) [DETECTED ON MICROSOFT ONLY]
     }
@@ -92,3 +92,12 @@ void h(int i, struct some_type *j, int k)
 	// going on.
 	printf("%i %R %i", i, j, k); // GOOD (as far as we can tell)
 }
+
+typedef long ptrdiff_t;
+
+void fun1(unsigned char* a, unsigned char* b) {
+  ptrdiff_t pdt;
+
+  printf("%td\n", pdt); // GOOD
+  printf("%td\n", a-b); // GOOD [FALSE POSITIVE]
+}

cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Microsoft/WrongTypeFormatArguments.expected

@@ -17,7 +17,9 @@
 | printf1.h:73:19:73:22 | c_st | This argument should be of type 'ssize_t' but is of type 'unsigned long long' |
 | printf1.h:74:19:74:22 | C_ST | This argument should be of type 'ssize_t' but is of type 'unsigned long long' |
 | printf1.h:75:19:75:28 | sizeof(<expr>) | This argument should be of type 'ssize_t' but is of type 'unsigned long long' |
+| printf1.h:82:23:82:35 | ... - ... | This argument should be of type 'ptrdiff_t' but is of type 'long long' |
 | printf1.h:84:23:84:35 | ... - ... | This argument should be of type 'ssize_t' but is of type 'long long' |
+| printf1.h:102:19:102:21 | ... - ... | This argument should be of type 'ptrdiff_t' but is of type 'long long' |
 | real_world.h:61:21:61:22 | & ... | This argument should be of type 'int *' but is of type 'short *' |
 | real_world.h:62:22:62:23 | & ... | This argument should be of type 'short *' but is of type 'int *' |
 | real_world.h:63:22:63:24 | & ... | This argument should be of type 'short *' but is of type 'unsigned int *' |

cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Microsoft/printf1.h

@@ -79,7 +79,7 @@ void g()
         char buf[100];
 
         printf("%tu", ptr_a - ptr_b); // ok
-        printf("%td", ptr_a - ptr_b); // ok
+        printf("%td", ptr_a - ptr_b); // ok [FALSE POSITIVE]
         printf("%zu", ptr_a - ptr_b); // ok (dubious) [DETECTED ON LINUX ONLY]
         printf("%zd", ptr_a - ptr_b); // ok (dubious) [DETECTED ON MICROSOFT ONLY]
     }
@@ -92,3 +92,12 @@ void h(int i, struct some_type *j, int k)
 	// going on.
 	printf("%i %R %i", i, j, k); // GOOD (as far as we can tell)
 }
+
+typedef long long ptrdiff_t;
+
+void fun1(unsigned char* a, unsigned char* b) {
+  ptrdiff_t pdt;
+
+  printf("%td\n", pdt); // GOOD
+  printf("%td\n", a-b); // GOOD [FALSE POSITIVE]
+}

cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Microsoft_no_wchar/WrongTypeFormatArguments.expected

@@ -17,7 +17,9 @@
 | printf1.h:73:19:73:22 | c_st | This argument should be of type 'ssize_t' but is of type 'unsigned long long' |
 | printf1.h:74:19:74:22 | C_ST | This argument should be of type 'ssize_t' but is of type 'unsigned long long' |
 | printf1.h:75:19:75:28 | sizeof(<expr>) | This argument should be of type 'ssize_t' but is of type 'unsigned long long' |
+| printf1.h:82:23:82:35 | ... - ... | This argument should be of type 'ptrdiff_t' but is of type 'long long' |
 | printf1.h:84:23:84:35 | ... - ... | This argument should be of type 'ssize_t' but is of type 'long long' |
+| printf1.h:102:19:102:21 | ... - ... | This argument should be of type 'ptrdiff_t' but is of type 'long long' |
 | real_world.h:61:21:61:22 | & ... | This argument should be of type 'int *' but is of type 'short *' |
 | real_world.h:62:22:62:23 | & ... | This argument should be of type 'short *' but is of type 'int *' |
 | real_world.h:63:22:63:24 | & ... | This argument should be of type 'short *' but is of type 'unsigned int *' |

cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Microsoft_no_wchar/printf1.h

@@ -79,7 +79,7 @@ void g()
         char buf[100];
 
         printf("%tu", ptr_a - ptr_b); // ok
-        printf("%td", ptr_a - ptr_b); // ok
+        printf("%td", ptr_a - ptr_b); // ok [FALSE POSITIVE]
         printf("%zu", ptr_a - ptr_b); // ok (dubious) [DETECTED ON LINUX ONLY]
         printf("%zd", ptr_a - ptr_b); // ok (dubious) [DETECTED ON MICROSOFT ONLY]
     }
@@ -92,3 +92,12 @@ void h(int i, struct some_type *j, int k)
 	// going on.
 	printf("%i %R %i", i, j, k); // GOOD (as far as we can tell)
 }
+
+typedef long long ptrdiff_t;
+
+void fun1(unsigned char* a, unsigned char* b) {
+  ptrdiff_t pdt;
+
+  printf("%td\n", pdt); // GOOD
+  printf("%td\n", a-b); // GOOD [FALSE POSITIVE]
+}