JS: Allow PropAccess when guessing name

asger-semmle · asger-semmle · commit b2fcea4fd229 · 2019-07-16T17:29:56.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/Classes.qll b/javascript/ql/src/semmle/javascript/Classes.qll
@@ -229,7 +229,7 @@ class ClassExpr extends @classexpr, ClassDefinition, Expr {
         result = p.getName()
       )
       or
-      exists(AssignExpr assign, DotExpr prop |
+      exists(AssignExpr assign, PropAccess prop |
         this = assign.getRhs().getUnderlyingValue() and
         prop = assign.getLhs() and
         result = prop.getPropertyName()
diff --git a/javascript/ql/src/semmle/javascript/Functions.qll b/javascript/ql/src/semmle/javascript/Functions.qll
@@ -67,7 +67,7 @@ class Function extends @function, Parameterized, TypeParameterized, StmtContaine
         result = p.getName()
       )
       or
-      exists(AssignExpr assign, DotExpr prop |
+      exists(AssignExpr assign, PropAccess prop |
         this = assign.getRhs().getUnderlyingValue() and
         prop = assign.getLhs() and
         result = prop.getPropertyName()

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ class ClassExpr extends @classexpr, ClassDefinition, Expr {`
`229`	`229`	`result = p.getName()`
`230`	`230`	`)`
`231`	`231`	`or`
`232`		`- exists(AssignExpr assign, DotExpr prop \|`
	`232`	`+ exists(AssignExpr assign, PropAccess prop \|`
`233`	`233`	`this = assign.getRhs().getUnderlyingValue() and`
`234`	`234`	`prop = assign.getLhs() and`
`235`	`235`	`result = prop.getPropertyName()`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ class Function extends @function, Parameterized, TypeParameterized, StmtContaine`
`67`	`67`	`result = p.getName()`
`68`	`68`	`)`
`69`	`69`	`or`
`70`		`- exists(AssignExpr assign, DotExpr prop \|`
	`70`	`+ exists(AssignExpr assign, PropAccess prop \|`
`71`	`71`	`this = assign.getRhs().getUnderlyingValue() and`
`72`	`72`	`prop = assign.getLhs() and`
`73`	`73`	`result = prop.getPropertyName()`