Skip to content

Commit b308c54

Browse files
committed
Java: Add a change note, and a minor ql comment.
1 parent e302616 commit b308c54

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: majorAnalysis
3+
---
4+
* The implementation of `java/dereferenced-value-may-be-null` has been completely replaced with a new general control-flow reachability library. This improves precision by reducing false positives. However, since the entire calculation has been reworked, there can be small corner cases where precision regressions might occur and new false positives may occur, but these cases should be rare.

shared/controlflow/codeql/controlflow/Guards.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ module Make<
210210
TValue(TAbstractSingleValue val, Boolean isVal) or
211211
TIntRange(int bound, Boolean upper) {
212212
exists(ConstantExpr c | c.asIntegerValue() + [-1, 0, 1] = bound) and
213+
// exclude edge cases to avoid overflow issues when computing duals
213214
bound != 2147483647 and
214215
bound != -2147483648
215216
} or

0 commit comments

Comments
 (0)