C++: Work around CPP-331

jbj · jbj · commit b38ca944f4d9 · 2019-01-11T11:26:43.000+01:00
This change suppresses results from "Declaration hides parameter" where
the ParameterDeclarationEntry does not link up to the right
FunctionDeclarationEntry.
diff --git a/cpp/ql/src/Best Practices/Hiding/DeclarationHidesParameter.ql b/cpp/ql/src/Best Practices/Hiding/DeclarationHidesParameter.ql
@@ -23,6 +23,7 @@ ParameterDeclarationEntry functionParameterNames(Function f, string name) {
     result.getFunctionDeclarationEntry() = fe and
     fe.getFunction() = f and
     fe.getLocation() = f.getDefinitionLocation() and
+    result.getFile() = fe.getFile() and // Work around CPP-331
     strictcount(f.getDefinitionLocation()) = 1 and
     result.getName() = name
   )

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ ParameterDeclarationEntry functionParameterNames(Function f, string name) {`
`23`	`23`	`result.getFunctionDeclarationEntry() = fe and`
`24`	`24`	`fe.getFunction() = f and`
`25`	`25`	`fe.getLocation() = f.getDefinitionLocation() and`
	`26`	`+ result.getFile() = fe.getFile() and // Work around CPP-331`
`26`	`27`	`strictcount(f.getDefinitionLocation()) = 1 and`
`27`	`28`	`result.getName() = name`
`28`	`29`	`)`