Merge remote-tracking branch 'origin/main' into criemen/new-pkg

Author: criemen

.bazelrc

@@ -10,10 +10,8 @@ common --override_module=semmle_code=%workspace%/misc/bazel/semmle_code_stub
 
 build --repo_env=CC=clang --repo_env=CXX=clang++
 
-build:linux --cxxopt=-std=c++20 --host_cxxopt=-std=c++20
-# we currently cannot built the swift extractor for ARM
-build:macos --cxxopt=-std=c++20 --host_cxxopt=-std=c++20 --copt=-arch --copt=x86_64 --linkopt=-arch --linkopt=x86_64
-build:windows --cxxopt=/std:c++20 --cxxopt=/Zc:preprocessor --host_cxxopt=/std:c++20 --host_cxxopt=/Zc:preprocessor
+# we use transitions that break builds of `...`, so for `test` to work with that we need the following
+test --build_tests_only
 
 # this requires developer mode, but is required to have pack installer functioning
 startup --windows_enable_symlinks

.github/workflows/go-tests-other-os.yml

@@ -7,6 +7,9 @@ on:
       - .github/workflows/go-tests-other-os.yml
       - .github/actions/**
       - codeql-workspace.yml
+      - MODULE.bazel
+      - .bazelrc
+      - misc/bazel/**
 
 permissions:
   contents: read

.github/workflows/go-tests.yml

@@ -15,6 +15,9 @@ on:
       - .github/workflows/go-tests.yml
       - .github/actions/**
       - codeql-workspace.yml
+      - MODULE.bazel
+      - .bazelrc
+      - misc/bazel/**
 
 permissions:
   contents: read

.github/workflows/swift.yml

@@ -68,21 +68,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: ./swift/actions/run-ql-tests
-  integration-tests-linux:
-    if: github.repository_owner == 'github'
-    needs: build-and-test-linux
-    runs-on: ubuntu-latest-xl
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./swift/actions/run-integration-tests
-  integration-tests-macos:
-    if: ${{ github.repository_owner == 'github' && github.event_name == 'pull_request' }}
-    needs: build-and-test-macos
-    runs-on: macos-12-xl
-    timeout-minutes: 60
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./swift/actions/run-integration-tests
   clang-format:
     if : ${{ github.event_name == 'pull_request' }}
     runs-on: ubuntu-latest

csharp/ql/integration-tests/legacy

@@ -0,0 +1 @@
+These tests are still run with the legacy test runner

csharp/ql/lib/ext/System.Data.model.yml

@@ -54,6 +54,12 @@ extensions:
       - ["System.Data", "EnumerableRowCollectionExtensions", False, "Where<TRow>", "(System.Data.EnumerableRowCollection<TRow>,System.Func<TRow,System.Boolean>)", "", "Argument[0].Element", "ReturnValue.Element", "value", "manual"]
       - ["System.Data", "IColumnMappingCollection", True, "get_Item", "(System.String)", "", "Argument[this].Element", "ReturnValue", "value", "manual"]
       - ["System.Data", "IColumnMappingCollection", True, "set_Item", "(System.String,System.Object)", "", "Argument[1]", "Argument[this].Element", "value", "manual"]
+      - ["System.Data", "IDataRecord", True, "GetString", "(System.Int32)", "", "Argument[this]", "ReturnValue", "taint", "manual"]
+      - ["System.Data", "IDataRecord", True, "GetValue", "(System.Int32)", "", "Argument[this]", "ReturnValue", "taint", "manual"]
+      - ["System.Data", "IDataRecord", True, "GetValues", "(System.Object[])", "", "Argument[this]", "Argument[0].Element", "taint", "manual"]
+      - ["System.Data", "IDataRecord", True, "get_Item", "(System.Int32)", "", "Argument[this]", "ReturnValue", "taint", "manual"]
+      - ["System.Data", "IDataRecord", True, "get_Item", "(System.String)", "", "Argument[this]", "ReturnValue", "taint", "manual"]
+      - ["System.Data", "IDbCommand", True, "ExecuteReader", "()", "", "Argument[this]", "ReturnValue", "taint", "manual"]
       - ["System.Data", "IDataParameterCollection", True, "get_Item", "(System.String)", "", "Argument[this].Element", "ReturnValue", "value", "manual"]
       - ["System.Data", "IDataParameterCollection", True, "set_Item", "(System.String,System.Object)", "", "Argument[1]", "Argument[this].Element", "value", "manual"]
       - ["System.Data", "ITableMappingCollection", True, "get_Item", "(System.String)", "", "Argument[this].Element", "ReturnValue", "value", "manual"]
@@ -73,3 +79,11 @@ extensions:
       - ["System.Data", "TypedTableBaseExtensions", False, "Select<TRow,S>", "(System.Data.TypedTableBase<TRow>,System.Func<TRow,S>)", "", "Argument[1].ReturnValue", "ReturnValue.Element", "value", "manual"]
       - ["System.Data", "TypedTableBaseExtensions", False, "Where<TRow>", "(System.Data.TypedTableBase<TRow>,System.Func<TRow,System.Boolean>)", "", "Argument[0].Element", "Argument[1].Parameter[0]", "value", "manual"]
       - ["System.Data", "TypedTableBaseExtensions", False, "Where<TRow>", "(System.Data.TypedTableBase<TRow>,System.Func<TRow,System.Boolean>)", "", "Argument[0].Element", "ReturnValue.Element", "value", "manual"]
+
+  - addsTo:
+      pack: codeql/csharp-all
+      extensible: neutralModel
+    data:
+      - ["System.Data", "IDataRecord", "GetDataTypeName", "(System.Int32)", "summary", "manual"]
+      - ["System.Data", "IDataRecord", "GetGuid", "(System.Int32)", "summary", "manual"]
+      - ["System.Data", "IDataRecord", "GetName", "(System.Int32)", "summary", "manual"]

csharp/ql/lib/ext/generated/ILCompiler.IBC.model.yml

@@ -5,7 +5,6 @@ extensions:
       extensible: summaryModel
     data:
       - ["ILCompiler.IBC", "IBCProfileData", False, "IBCProfileData", "(ILCompiler.IBC.MibcConfig,System.Boolean,System.Collections.Generic.IEnumerable<ILCompiler.MethodProfileData>)", "", "Argument[0]", "Argument[this]", "taint", "df-generated"]
-      - ["ILCompiler.IBC", "IBCProfileData", False, "get_Config", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
       - ["ILCompiler.IBC", "MibcConfig", False, "FromKeyValueMap", "(System.Collections.Generic.Dictionary<System.String,System.String>)", "", "Argument[0].Element", "ReturnValue", "taint", "df-generated"]
       - ["ILCompiler.IBC", "MibcConfig", False, "ToString", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
   - addsTo:

csharp/ql/lib/ext/generated/ILCompiler.Reflection.ReadyToRun.model.yml

@@ -13,6 +13,8 @@ extensions:
       - ["ILCompiler.Reflection.ReadyToRun", "EHInfo", False, "get_EHClauses", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "GCRefMap", False, "GCRefMap", "(System.UInt32,ILCompiler.Reflection.ReadyToRun.GCRefMapEntry[])", "", "Argument[1].Element", "Argument[this]", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "GCRefMapDecoder", False, "GCRefMapDecoder", "(ILCompiler.Reflection.ReadyToRun.ReadyToRunReader,System.Int32)", "", "Argument[0]", "Argument[this]", "taint", "df-generated"]
+      - ["ILCompiler.Reflection.ReadyToRun", "IAssemblyMetadata", True, "get_ImageReader", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
+      - ["ILCompiler.Reflection.ReadyToRun", "IAssemblyMetadata", True, "get_MetadataReader", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "InliningInfoSection2", False, "InliningInfoSection2", "(ILCompiler.Reflection.ReadyToRun.ReadyToRunReader,System.Int32,System.Int32)", "", "Argument[0]", "Argument[this]", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "InliningInfoSection", False, "InliningInfoSection", "(ILCompiler.Reflection.ReadyToRun.ReadyToRunReader,System.Int32,System.Int32)", "", "Argument[0]", "Argument[this]", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "InstanceMethod", False, "InstanceMethod", "(System.Byte,ILCompiler.Reflection.ReadyToRun.ReadyToRunMethod)", "", "Argument[1]", "Argument[this]", "taint", "df-generated"]
@@ -66,8 +68,6 @@ extensions:
       - ["ILCompiler.Reflection.ReadyToRun", "RuntimeFunction", False, "get_EHInfo", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "SignatureDecoder", False, "GetMetadataReaderFromModuleOverride", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "StandaloneAssemblyMetadata", False, "StandaloneAssemblyMetadata", "(System.Reflection.PortableExecutable.PEReader)", "", "Argument[0]", "Argument[this]", "taint", "df-generated"]
-      - ["ILCompiler.Reflection.ReadyToRun", "StandaloneAssemblyMetadata", False, "get_ImageReader", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
-      - ["ILCompiler.Reflection.ReadyToRun", "StandaloneAssemblyMetadata", False, "get_MetadataReader", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "StringBuilderExtensions", False, "AppendEscapedString", "(System.Text.StringBuilder,System.String,System.Boolean)", "", "Argument[0]", "ReturnValue", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "StringTypeProviderBase<TGenericContext>", True, "GetArrayType", "(System.String,System.Reflection.Metadata.ArrayShape)", "", "Argument[0]", "ReturnValue", "taint", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "StringTypeProviderBase<TGenericContext>", True, "GetByReferenceType", "(System.String)", "", "Argument[0]", "ReturnValue", "taint", "df-generated"]
@@ -113,8 +113,6 @@ extensions:
       - ["ILCompiler.Reflection.ReadyToRun", "GCRefMapEntry", "GCRefMapEntry", "(System.Int32,ILCompiler.Reflection.ReadyToRun.CORCOMPILE_GCREFMAP_TOKENS)", "summary", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "GcStackSlot", "GcStackSlot", "(System.Int32,ILCompiler.Reflection.ReadyToRun.GcStackSlotBase)", "summary", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "GcStackSlot", "ToString", "()", "summary", "df-generated"]
-      - ["ILCompiler.Reflection.ReadyToRun", "IAssemblyMetadata", "get_ImageReader", "()", "summary", "df-generated"]
-      - ["ILCompiler.Reflection.ReadyToRun", "IAssemblyMetadata", "get_MetadataReader", "()", "summary", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "IAssemblyResolver", "FindAssembly", "(System.Reflection.Metadata.MetadataReader,System.Reflection.Metadata.AssemblyReferenceHandle,System.String)", "summary", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "IAssemblyResolver", "FindAssembly", "(System.String,System.String)", "summary", "df-generated"]
       - ["ILCompiler.Reflection.ReadyToRun", "IR2RSignatureTypeProvider<TType,TMethod,TGenericContext>", "GetCanonType", "()", "summary", "df-generated"]

csharp/ql/lib/ext/generated/ILCompiler.model.yml

@@ -7,19 +7,18 @@ extensions:
       - ["ILCompiler", "MethodProfileData", False, "MethodProfileData", "(Internal.TypeSystem.MethodDesc,ILCompiler.MethodProfilingDataFlags,System.Double,System.Collections.Generic.Dictionary<Internal.TypeSystem.MethodDesc,System.Int32>,System.UInt32,Internal.Pgo.PgoSchemaElem[])", "", "Argument[0]", "Argument[this]", "taint", "df-generated"]
       - ["ILCompiler", "MethodProfileData", False, "MethodProfileData", "(Internal.TypeSystem.MethodDesc,ILCompiler.MethodProfilingDataFlags,System.Double,System.Collections.Generic.Dictionary<Internal.TypeSystem.MethodDesc,System.Int32>,System.UInt32,Internal.Pgo.PgoSchemaElem[])", "", "Argument[3].Element", "Argument[this]", "taint", "df-generated"]
       - ["ILCompiler", "MethodProfileData", False, "MethodProfileData", "(Internal.TypeSystem.MethodDesc,ILCompiler.MethodProfilingDataFlags,System.Double,System.Collections.Generic.Dictionary<Internal.TypeSystem.MethodDesc,System.Int32>,System.UInt32,Internal.Pgo.PgoSchemaElem[])", "", "Argument[5].Element", "Argument[this]", "taint", "df-generated"]
+      - ["ILCompiler", "ProfileData", True, "get_Config", "()", "", "Argument[this]", "ReturnValue", "taint", "df-generated"]
   - addsTo:
       pack: codeql/csharp-all
       extensible: neutralModel
     data:
       - ["ILCompiler", "EmptyProfileData", "GetAllMethodProfileData", "()", "summary", "df-generated"]
       - ["ILCompiler", "EmptyProfileData", "GetMethodBlockCount", "(Internal.TypeSystem.MethodDesc)", "summary", "df-generated"]
       - ["ILCompiler", "EmptyProfileData", "GetMethodProfileData", "(Internal.TypeSystem.MethodDesc)", "summary", "df-generated"]
-      - ["ILCompiler", "EmptyProfileData", "get_Config", "()", "summary", "df-generated"]
       - ["ILCompiler", "EmptyProfileData", "get_PartialNGen", "()", "summary", "df-generated"]
       - ["ILCompiler", "EmptyProfileData", "get_Singleton", "()", "summary", "df-generated"]
       - ["ILCompiler", "ProfileData", "GetAllMethodProfileData", "()", "summary", "df-generated"]
       - ["ILCompiler", "ProfileData", "GetMethodBlockCount", "(Internal.TypeSystem.MethodDesc)", "summary", "df-generated"]
       - ["ILCompiler", "ProfileData", "GetMethodProfileData", "(Internal.TypeSystem.MethodDesc)", "summary", "df-generated"]
       - ["ILCompiler", "ProfileData", "MergeProfileData", "(System.Collections.Generic.Dictionary<Internal.TypeSystem.MethodDesc,ILCompiler.MethodProfileData>,ILCompiler.ProfileData)", "summary", "df-generated"]
-      - ["ILCompiler", "ProfileData", "get_Config", "()", "summary", "df-generated"]
       - ["ILCompiler", "ProfileData", "get_PartialNGen", "()", "summary", "df-generated"]