Python: Extend hasAttribute to unknown-but-defined module variables.

taus-semmle · taus-semmle · commit b9ef8a0526b0 · 2019-08-22T16:22:53.000+02:00
diff --git a/python/ql/src/semmle/python/types/ModuleObject.qll b/python/ql/src/semmle/python/types/ModuleObject.qll
@@ -54,6 +54,8 @@ abstract class ModuleObject extends Object {
 
     predicate hasAttribute(string name) {
         exists(theModule().attr(name))
+        or
+        exists(SsaVariable var | name = var.getId() and var.getAUse() = this.getModule().getANormalExit())
     }
 
     predicate attributeRefersTo(string name, Object obj, ControlFlowNode origin) {

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,8 @@ abstract class ModuleObject extends Object {`
`54`	`54`
`55`	`55`	`predicate hasAttribute(string name) {`
`56`	`56`	`exists(theModule().attr(name))`
	`57`	`+ or`
	`58`	`+ exists(SsaVariable var \| name = var.getId() and var.getAUse() = this.getModule().getANormalExit())`
`57`	`59`	`}`
`58`	`60`
`59`	`61`	`predicate attributeRefersTo(string name, Object obj, ControlFlowNode origin) {`