Merge pull request #1219 from geoffw0/msfix2

CPP: Fix FormatLiteral.isMicrosoft

Author: jbj

cpp/ql/src/semmle/code/cpp/File.qll

@@ -298,7 +298,12 @@ class File extends Container, @file {
     none()
   }
 
-  /** Holds if this file was compiled by a Microsoft compiler (at any point). */
+  /**
+   * Holds if this file was compiled by a Microsoft compiler (at any point).
+   *
+   * Note: currently unreliable - on some projects only some of the files that
+   * are compiled by a Microsoft compiler are detected by this predicate.
+   */
   predicate compiledAsMicrosoft() {
     exists(Compilation c |
       c.getAFileCompiled() = this and

cpp/ql/src/semmle/code/cpp/commons/Printf.qll

@@ -250,7 +250,7 @@ class FormatLiteral extends Literal {
    * Microsoft rules and extensions.
    */
   predicate isMicrosoft() {
-    getFile().compiledAsMicrosoft()
+    any(File f).compiledAsMicrosoft()
   }
 
   /**

cpp/ql/src/semmle/code/cpp/models/interfaces/FormattingFunction.qll

@@ -51,7 +51,7 @@ abstract class FormattingFunction extends Function {
    * Microsoft rules and extensions.
    */
   predicate isMicrosoft() {
-    getFile().compiledAsMicrosoft()
+    any(File f).compiledAsMicrosoft()
   }
 
   /**