Skip to content

Commit bc2785d

Browse files
author
Esben Sparre Andreasen
committed
JS: add missing binding for this in BuiltinServiceCall
1 parent bc296e7 commit bc2785d

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

javascript/ql/src/semmle/javascript/frameworks/AngularJS/AngularJSCore.qll

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,8 @@ private class BuiltinServiceCall extends AngularJSCall {
719719
BuiltinServiceCall() {
720720
exists(BuiltinServiceReference service |
721721
service.getAMethodCall(_) = this or
722-
service.getACall() = this |
722+
service.getACall() = this
723+
|
723724
call = this
724725
)
725726
}
@@ -769,23 +770,25 @@ private class BuiltinServiceCall extends AngularJSCall {
769770
methodName = "$watchCollection" or
770771
methodName = "$watchGroup"
771772
|
772-
e = scope.getAMethodCall(methodName).getArgument(0)
773+
call = scope.getAMethodCall(methodName) and
774+
e = call.getArgument(0)
773775
)
774776
or
775777
exists(ServiceReference service |
776778
service.getName() = "$compile" or
777779
service.getName() = "$parse" or
778780
service.getName() = "$interpolate"
779781
|
780-
e = service.getACall().getArgument(0)
782+
call = service.getACall() and
783+
e = call.getArgument(0)
781784
)
782785
or
783-
exists(ServiceReference service, CallExpr filter, CallExpr filterInvocation |
786+
exists(ServiceReference service, CallExpr filterInvocation |
784787
// `$filter('orderBy')(collection, expression)`
785788
service.getName() = "$filter" and
786-
filter = service.getACall() and
787-
filter.getArgument(0).mayHaveStringValue("orderBy") and
788-
filterInvocation.getCallee() = filter and
789+
call = service.getACall() and
790+
call.getArgument(0).mayHaveStringValue("orderBy") and
791+
filterInvocation.getCallee() = call and
789792
e = filterInvocation.getArgument(1)
790793
)
791794
}

0 commit comments

Comments
 (0)