Update javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll

dellalibera · esbena · web-flow · commit bfef84e1b579 · 2020-08-16T14:32:05.000+02:00
Co-authored-by: Esben Sparre Andreasen &lt;esbena@github.com&gt;
diff --git a/javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll b/javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll
@@ -97,10 +97,7 @@ module InsecureCookie {
     override predicate isInsecure() {
         // A cookie is insecure if there are not cookie options with the `secure` flag set to `true`.
 
-      not exists(DataFlow::SourceNode cookieOptions |
-        cookieOptions = this.getCookieOptionsArgument() and
-        getCookieFlagValue(flag()).mayHaveBooleanValue(true)
-      )
+      not getCookieFlagValue(flag()).mayHaveBooleanValue(true)    
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -97,10 +97,7 @@ module InsecureCookie {`
`97`	`97`	`override predicate isInsecure() {`
`98`	`98`	// A cookie is insecure if there are not cookie options with the `secure` flag set to `true`.
`99`	`99`
`100`		`- not exists(DataFlow::SourceNode cookieOptions \|`
`101`		`- cookieOptions = this.getCookieOptionsArgument() and`
`102`		`- getCookieFlagValue(flag()).mayHaveBooleanValue(true)`
`103`		`- )`
	`100`	`+ not getCookieFlagValue(flag()).mayHaveBooleanValue(true)`
`104`	`101`	`}`
`105`	`102`	`}`
`106`	`103`