made the blacklist for methods named "function" work again

Author: erik-krogh

javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql

@@ -52,7 +52,7 @@ where
     // The developer was not confused about "function" when there are other methods in the interface.
     name = "function" and 
     exists(MethodDeclaration other | other = container.getAMethod() |
-      name != "function" and
+      other.getName() != "function" and
       not other.(ConstructorDeclaration).isSynthetic()
     )
   )

javascript/ql/test/query-tests/Declarations/SuspiciousMethodNameDeclaration/SuspiciousMethodNameDeclaration.expected

@@ -1,4 +1,3 @@
-| tst.ts:4:3:4:22 | function (): number; | The member name 'function' does not declare a function, it declares a method named 'function'. |
 | tst.ts:7:3:7:24 | constru ... string; | The member name 'constructor' does not declare a constructor in interface declarations, but it does in class declarations. |
 | tst.ts:16:3:16:21 | function(): number; | The member name 'function' does not declare a function, it declares a method named 'function'. |
 | tst.ts:37:3:37:21 | function(): number; | The member name 'function' does not declare a function, it declares a method named 'function'. |