|
| 1 | +"""testing views for Django 2.x and 3.x""" |
| 2 | +from django.urls import path |
| 3 | +from django.http import HttpRequest |
| 4 | + |
| 5 | + |
| 6 | +def test_taint(request: HttpRequest, foo, bar, baz=None): # $routeHandler $routedParameter=foo $routedParameter=bar |
| 7 | + ensure_tainted(foo, bar) |
| 8 | + ensure_not_tainted(baz) |
| 9 | + |
| 10 | + # Manually inspected all fields of the HttpRequest object |
| 11 | + # https://docs.djangoproject.com/en/3.0/ref/request-response/#httprequest-objects |
| 12 | + |
| 13 | + ensure_tainted( |
| 14 | + request, |
| 15 | + |
| 16 | + request.body, |
| 17 | + request.path, |
| 18 | + request.path_info, |
| 19 | + |
| 20 | + # With CSRF middleware disabled, it's possible to use custom methods, |
| 21 | + # for example by `curl -X FOO <url>` |
| 22 | + request.method, |
| 23 | + |
| 24 | + request.encoding, |
| 25 | + request.content_type, |
| 26 | + |
| 27 | + # Dict[str, str] |
| 28 | + request.content_params, |
| 29 | + request.content_params["key"], |
| 30 | + request.content_params.get("key"), |
| 31 | + |
| 32 | + # django.http.QueryDict |
| 33 | + # see https://docs.djangoproject.com/en/3.0/ref/request-response/#querydict-objects |
| 34 | + request.GET, |
| 35 | + request.GET["key"], |
| 36 | + request.GET.get("key"), |
| 37 | + request.GET.getlist("key"), |
| 38 | + request.GET.getlist("key")[0], |
| 39 | + request.GET.pop("key"), |
| 40 | + request.GET.pop("key")[0], |
| 41 | + request.GET.popitem()[0], # key |
| 42 | + request.GET.popitem()[1], # values |
| 43 | + request.GET.popitem()[1][0], # values[0] |
| 44 | + request.GET.dict(), |
| 45 | + request.GET.dict()["key"], |
| 46 | + request.GET.urlencode(), |
| 47 | + |
| 48 | + # django.http.QueryDict (same as above, did not duplicate tests) |
| 49 | + request.POST, |
| 50 | + |
| 51 | + # Dict[str, str] |
| 52 | + request.COOKIES, |
| 53 | + request.COOKIES["key"], |
| 54 | + request.COOKIES.get("key"), |
| 55 | + |
| 56 | + # MultiValueDict[str, UploadedFile] |
| 57 | + request.FILES, |
| 58 | + request.FILES["key"], |
| 59 | + request.FILES["key"].content_type, |
| 60 | + request.FILES["key"].content_type_extra, |
| 61 | + request.FILES["key"].content_type_extra["key"], |
| 62 | + request.FILES["key"].charset, |
| 63 | + request.FILES["key"].name, |
| 64 | + request.FILES["key"].file, |
| 65 | + request.FILES["key"].file.read(), |
| 66 | + |
| 67 | + request.FILES.get("key"), |
| 68 | + request.FILES.get("key").name, |
| 69 | + request.FILES.getlist("key"), |
| 70 | + request.FILES.getlist("key")[0], |
| 71 | + request.FILES.getlist("key")[0].name, |
| 72 | + request.FILES.dict(), |
| 73 | + request.FILES.dict()["key"], |
| 74 | + request.FILES.dict()["key"].name, |
| 75 | + |
| 76 | + # Dict[str, Any] |
| 77 | + request.META, |
| 78 | + request.META["HTTP_USER_AGENT"], |
| 79 | + request.META.get("HTTP_USER_AGENT"), |
| 80 | + |
| 81 | + # HttpHeaders (case insensitive dict-like) |
| 82 | + request.headers, |
| 83 | + request.headers["user-agent"], |
| 84 | + request.headers["USER_AGENT"], |
| 85 | + |
| 86 | + # django.urls.ResolverMatch |
| 87 | + request.resolver_match, |
| 88 | + request.resolver_match.args, |
| 89 | + request.resolver_match.args[0], |
| 90 | + request.resolver_match.kwargs, |
| 91 | + request.resolver_match.kwargs["key"], |
| 92 | + |
| 93 | + request.get_full_path(), |
| 94 | + request.get_full_path_info(), |
| 95 | + # build_absolute_uri handled below |
| 96 | + # get_signed_cookie handled below |
| 97 | + |
| 98 | + request.read(), |
| 99 | + request.readline(), |
| 100 | + request.readlines(), |
| 101 | + request.readlines()[0], |
| 102 | + [line for line in request], |
| 103 | + ) |
| 104 | + |
| 105 | + # django.urls.ResolverMatch also supports iterable unpacking |
| 106 | + _view, args, kwargs = request.resolver_match |
| 107 | + ensure_tainted( |
| 108 | + args, |
| 109 | + args[0], |
| 110 | + kwargs, |
| 111 | + kwargs["key"], |
| 112 | + ) |
| 113 | + |
| 114 | + ensure_not_tainted( |
| 115 | + request.current_app, |
| 116 | + |
| 117 | + # Django has `ALLOWED_HOSTS` to ensure the HOST value cannot be tampered with. |
| 118 | + # It is possible to remove this protection, but it seems reasonable to assume |
| 119 | + # people don"t do this by default. |
| 120 | + request.get_host(), |
| 121 | + request.get_port(), |
| 122 | + ) |
| 123 | + |
| 124 | + #################################### |
| 125 | + # build_absolute_uri |
| 126 | + #################################### |
| 127 | + ensure_tainted( |
| 128 | + request.build_absolute_uri(), |
| 129 | + request.build_absolute_uri(request.GET["key"]), |
| 130 | + request.build_absolute_uri(location=request.GET["key"]), |
| 131 | + ) |
| 132 | + ensure_not_tainted( |
| 133 | + request.build_absolute_uri("/hardcoded/"), |
| 134 | + request.build_absolute_uri("https://example.com"), |
| 135 | + ) |
| 136 | + |
| 137 | + #################################### |
| 138 | + # get_signed_cookie |
| 139 | + #################################### |
| 140 | + # We don't consider user to be able to tamper with cookies that are signed |
| 141 | + ensure_not_tainted( |
| 142 | + request.get_signed_cookie("key"), |
| 143 | + request.get_signed_cookie("key", salt="salt"), |
| 144 | + request.get_signed_cookie("key", max_age=60), |
| 145 | + ) |
| 146 | + # However, providing tainted default value might result in taint |
| 147 | + ensure_tainted( |
| 148 | + request.get_signed_cookie("key", request.COOKIES["key"]), |
| 149 | + request.get_signed_cookie("key", default=request.COOKIES["key"]), |
| 150 | + ) |
| 151 | + |
| 152 | + |
| 153 | +# fake setup, you can't actually run this |
| 154 | +urlpatterns = [ |
| 155 | + path("test-taint/<foo>/<bar>", test_taint), # $routeSetup="test-taint/<foo>/<bar>" |
| 156 | +] |
0 commit comments