Skip to content

Commit c143e31

Browse files
author
Esben Sparre Andreasen
committed
JS: rename getDefaultNode to getImportedModuleNode
1 parent 0660db3 commit c143e31

File tree

7 files changed

+8
-8
lines changed

7 files changed

+8
-8
lines changed

javascript/ql/src/semmle/javascript/AMD.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ private class AmdDependencyImport extends Import {
264264
result = resolveByAbsolutePath()
265265
}
266266

267-
override DataFlow::Node getDefaultNode() {
267+
override DataFlow::Node getImportedModuleNode() {
268268
exists(Parameter param |
269269
any(AmdModuleDefinition def).dependencyParameter(this, param) and
270270
result = DataFlow::parameterNode(param)

javascript/ql/src/semmle/javascript/ES2015Modules.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class ImportDeclaration extends Stmt, Import, @importdeclaration {
4444
/** Gets an import specifier of this import declaration. */
4545
ImportSpecifier getASpecifier() { result = getSpecifier(_) }
4646

47-
override DataFlow::Node getDefaultNode() {
47+
override DataFlow::Node getImportedModuleNode() {
4848
// `import * as http from 'http'` or `import http from `http`'
4949
exists(ImportSpecifier is |
5050
is = getASpecifier() and

javascript/ql/src/semmle/javascript/Expr.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1563,7 +1563,7 @@ class DynamicImportExpr extends @dynamicimport, Expr, Import {
15631563

15641564
override Module getEnclosingModule() { result = getTopLevel() }
15651565

1566-
override DataFlow::Node getDefaultNode() { result = DataFlow::valueNode(this) }
1566+
override DataFlow::Node getImportedModuleNode() { result = DataFlow::valueNode(this) }
15671567
}
15681568

15691569
/** A literal path expression appearing in a dynamic import. */

javascript/ql/src/semmle/javascript/Modules.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ abstract class Import extends ASTNode {
164164
/**
165165
* Gets the data flow node that the default import of this import is available at.
166166
*/
167-
abstract DataFlow::Node getDefaultNode();
167+
abstract DataFlow::Node getImportedModuleNode();
168168
}
169169

170170
/**

javascript/ql/src/semmle/javascript/NodeJS.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ class Require extends CallExpr, Import {
235235
)
236236
}
237237

238-
override DataFlow::Node getDefaultNode() { result = DataFlow::valueNode(this) }
238+
override DataFlow::Node getImportedModuleNode() { result = DataFlow::valueNode(this) }
239239
}
240240

241241
/** An argument to `require` or `require.resolve`, considered as a path expression. */

javascript/ql/src/semmle/javascript/TypeScript.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ class ExternalModuleReference extends Expr, Import, @externalmodulereference {
213213
result = getExpression().getFirstControlFlowNode()
214214
}
215215

216-
override DataFlow::Node getDefaultNode() { result = DataFlow::valueNode(this) }
216+
override DataFlow::Node getImportedModuleNode() { result = DataFlow::valueNode(this) }
217217
}
218218

219219
/** A literal path expression appearing in an external module reference. */

javascript/ql/src/semmle/javascript/dataflow/Nodes.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ module ModuleImportNode {
463463

464464
DefaultRange() {
465465
exists(Import i |
466-
this = i.getDefaultNode() and
466+
this = i.getImportedModuleNode() and
467467
i.getImportedPath().getValue() = path
468468
)
469469
or
@@ -494,7 +494,7 @@ ModuleImportNode moduleImport(string path) { result.getPath() = path }
494494
* `"lodash"` as a dependency.
495495
*/
496496
ModuleImportNode dependencyModuleImport(Dependency dep) {
497-
result = dep.getAUse("import").(Import).getDefaultNode()
497+
result = dep.getAUse("import").(Import).getImportedModuleNode()
498498
}
499499

500500
/**

0 commit comments

Comments
 (0)