Skip to content

Commit c47a9dd

Browse files
MathiasVPCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 7aca94b commit c47a9dd

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1041,7 +1041,7 @@ private module Cached {
10411041
av.isFalse() and result.asBooleanValue() = false
10421042
or
10431043
// NOTE: The below cases don't contribute anything currently since the
1044-
// callers immediate uses `.asBooleanValue()` to convert the `GuardValue`
1044+
// callers immediately use `.asBooleanValue()` to convert the `GuardValue`
10451045
// to a boolean. Once we're willing to accept the breaking change of
10461046
// converting the barrier guard API to use `GuardValue`s instead `Boolean`s
10471047
// we can remove this restriction.

cpp/ql/test/library-tests/dataflow/ir-barrier-guards/test.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ bool is_clean_value(int*);
2020
int* get_clean_pointer(int* x) { return x; }
2121
bool is_clean_pointer(int*);
2222

23-
void sink(int);
2423
void sink(int*);
2524

2625
void test_mad(int x, int* p) {

cpp/ql/test/library-tests/dataflow/ir-barrier-guards/test.ext.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ extensions:
66
- ["", "", False, "get_clean_pointer", "", "", "ReturnValue", "test-barrier", "manual"]
77
- ["", "", False, "get_clean_data", "", "", "ReturnValue[*]", "test-barrier", "manual"]
88
- addsTo:
9-
pack: codeql/cpp-all
10-
extensible: barrierGuardModel
9+
pack: codeql/cpp-all
10+
extensible: barrierGuardModel
1111
data:
1212
- ["", "", False, "is_clean_value", "", "", "Argument[*0]", "true", "test-barrier", "manual"]
1313
- ["", "", False, "is_clean_pointer", "", "", "Argument[0]", "true", "test-barrier", "manual"]

0 commit comments

Comments
 (0)