Skip to content

Commit c64a676

Browse files
committed
Merge branch 'UncheckedLeaprYearAfterModification_Refactor_Upstream' of https://github.com/microsoft/codeql into UncheckedLeaprYearAfterModification_Refactor_Upstream
2 parents f7231f4 + a53218c commit c64a676

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
22
category: minorAnalysis
33
---
4-
* Refactor of UncheckedLeapYearAfterYearModification.ql to address large numbers of false positives. Reduced alerts from 40k to 2k.
4+
* Refactored the "Year field changed using an arithmetic operation without checking for leap year" query (`cpp/leap-year/unchecked-after-arithmetic-year-modification`) to address large numbers of false positive results.

cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -783,7 +783,7 @@ class LeapYearGuardCondition extends GuardCondition {
783783
* ... values eventually used in the same time struct
784784
* If this is even more challenging if the struct the values end up in are not
785785
* local (set inter-procedurally).
786-
* This flow flows constants 1-31 to a month or day assignment.
786+
* This configuration looks for constants 1-31 flowing to a month or day assignment.
787787
* It is assumed a user of this flow will check if the month/day source and month/day sink
788788
* are in the same basic blocks as a year modification source and a year modification sink.
789789
* It is also assumed a user will check if the constant source is a value that is ignorable

0 commit comments

Comments
 (0)