Merge pull request #5851 from github/alexet/patch

alexet · web-flow · commit c80495fbdd2c · 2021-05-19T12:00:07.000+01:00
Use only_bind_out to force a good join order.
diff --git a/csharp/ql/src/semmle/code/csharp/dispatch/Dispatch.qll b/csharp/ql/src/semmle/code/csharp/dispatch/Dispatch.qll
@@ -387,7 +387,8 @@ private module Internal {
       result = this.getAStaticTarget()
       or
       result.getUnboundDeclaration() =
-        this.getASubsumedStaticTarget0(Gvn::getGlobalValueNumber(result.getDeclaringType()))
+        this.getASubsumedStaticTarget0(pragma[only_bind_out](Gvn::getGlobalValueNumber(result
+                .getDeclaringType())))
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,8 @@ private module Internal {`
`387`	`387`	`result = this.getAStaticTarget()`
`388`	`388`	`or`
`389`	`389`	`result.getUnboundDeclaration() =`
`390`		`- this.getASubsumedStaticTarget0(Gvn::getGlobalValueNumber(result.getDeclaringType()))`
	`390`	`+ this.getASubsumedStaticTarget0(pragma[only_bind_out](Gvn::getGlobalValueNumber(result`
	`391`	`+ .getDeclaringType())))`
`391`	`392`	`}`
`392`	`393`
`393`	`394`	`/**`