Skip to content

Commit c9ea5ad

Browse files
committed
C#/Java: Remove cached from wrapper predicate
1 parent 4b7813b commit c9ea5ad

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

csharp/ql/src/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,14 @@ module LocalFlow {
220220
}
221221
}
222222

223+
/**
224+
* Holds if data flows from `nodeFrom` to `nodeTo` in exactly one local
225+
* (intra-procedural) step.
226+
*/
227+
predicate localFlowStepImpl(Node nodeFrom, Node nodeTo) {
228+
simpleLocalFlowStep(nodeFrom, nodeTo)
229+
}
230+
223231
/** A collection of cached types and predicates to be evaluated in the same stage. */
224232
cached
225233
private module Cached {
@@ -249,15 +257,6 @@ private module Cached {
249257
} or
250258
TMallocNode(ControlFlow::Nodes::ElementNode cfn) { cfn.getElement() instanceof ObjectCreation }
251259

252-
/**
253-
* Holds if data flows from `nodeFrom` to `nodeTo` in exactly one local
254-
* (intra-procedural) step.
255-
*/
256-
cached
257-
predicate localFlowStepImpl(Node nodeFrom, Node nodeTo) {
258-
simpleLocalFlowStep(nodeFrom, nodeTo)
259-
}
260-
261260
/**
262261
* INTERNAL: do not use.
263262
*

java/ql/src/semmle/code/java/dataflow/internal/DataFlowUtil.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,6 @@ predicate hasNonlocalValue(FieldRead fr) {
350350
/**
351351
* Holds if data can flow from `node1` to `node2` in one local step.
352352
*/
353-
cached
354353
predicate localFlowStep(Node node1, Node node2) {
355354
simpleLocalFlowStep(node1, node2)
356355
}

0 commit comments

Comments
 (0)