Skip to content

Commit ca90383

Browse files
Java: Add this. and fix mistake
1 parent 5d487b9 commit ca90383

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

java/ql/src/semmle/code/java/dataflow/FlowSteps.qll

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,12 @@ abstract class TaintPreservingMethod extends Method {
5353

5454
private class StringTaintPreservingMethod extends TaintPreservingMethod {
5555
StringTaintPreservingMethod() {
56-
getDeclaringType() instanceof TypeString and
57-
hasName(["concat", "copyValueOf", "endsWith", "format", "formatted", "getBytes", "indent",
58-
"intern", "join", "repeat", "split", "strip", "stripIndent", "stripLeading",
59-
"stripTrailing", "substring", "toCharArray", "toLowerCase", "toString", "toUpperCase",
60-
"trim"])
56+
this.getDeclaringType() instanceof TypeString and
57+
this
58+
.hasName(["concat", "copyValueOf", "endsWith", "format", "formatted", "getBytes", "indent",
59+
"intern", "join", "repeat", "split", "strip", "stripIndent", "stripLeading",
60+
"stripTrailing", "substring", "toCharArray", "toLowerCase", "toString", "toUpperCase",
61+
"trim"])
6162
}
6263

6364
override predicate returnsTaint(int arg) {

java/ql/src/semmle/code/java/frameworks/android/SQLite.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ private class QueryBuilderBuildMethod extends TaintPreservingMethod {
232232
int argument;
233233

234234
QueryBuilderBuildMethod() {
235-
this.getDeclaringType().getASourceSupertype*() instanceof Class and
235+
this.getDeclaringType().getASourceSupertype*() instanceof TypeSQLiteQueryBuilder and
236236
// buildQuery(String[] projectionIn, String selection, String groupBy, String having, String sortOrder, String limit)
237237
// buildQuery(String[] projectionIn, String selection, String[] selectionArgs, String groupBy, String having, String sortOrder, String limit)
238238
// buildUnionQuery(String[] subQueries, String sortOrder, String limit)

0 commit comments

Comments
 (0)