Skip to content

Commit cad259f

Browse files
committed
JS: Use more types in DOM model
1 parent 3dabff6 commit cad259f

File tree

1 file changed

+10
-2
lines changed
  • javascript/ql/src/semmle/javascript

1 file changed

+10
-2
lines changed

javascript/ql/src/semmle/javascript/DOM.qll

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,11 @@ module DOM {
347347
}
348348

349349
/** Gets a data flow node that may refer to a value from the DOM. */
350-
DataFlow::SourceNode domValueRef() { result = domValueRef(DataFlow::TypeTracker::end()) }
350+
DataFlow::SourceNode domValueRef() {
351+
result = domValueRef(DataFlow::TypeTracker::end())
352+
or
353+
result.hasUnderlyingType("Element")
354+
}
351355

352356
module LocationSource {
353357
/**
@@ -419,5 +423,9 @@ module DOM {
419423
/**
420424
* Gets a reference to the 'document' object.
421425
*/
422-
DataFlow::SourceNode documentRef() { result = documentRef(DataFlow::TypeTracker::end()) }
426+
DataFlow::SourceNode documentRef() {
427+
result = documentRef(DataFlow::TypeTracker::end())
428+
or
429+
result.hasUnderlyingType("Document")
430+
}
423431
}

0 commit comments

Comments
 (0)