C++: Concretize ConstantAnalysis NegateInstruction

This is just to make the QL shorter. It generates the same DIL.

Author: jbj

cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/constant/ConstantAnalysis.qll

@@ -6,13 +6,7 @@ language[monotonicAggregates]
 int getConstantValue(Instruction instr) {
   result = instr.(IntegerConstantInstruction).getValue().toInt() or
   result = getBinaryInstructionValue(instr) or
-  exists(UnaryInstruction unaryInstr, int src |
-    unaryInstr = instr and
-    src = getConstantValue(unaryInstr.getOperand()) and
-    (
-      unaryInstr instanceof NegateInstruction and result = neg(src)
-    )
-  ) or
+  result = neg(getConstantValue(instr.(NegateInstruction).getOperand())) or
   result = getConstantValue(instr.(CopyInstruction).getSourceValue()) or
   exists(PhiInstruction phi |
     phi = instr and

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/constant/ConstantAnalysis.qll

@@ -6,13 +6,7 @@ language[monotonicAggregates]
 int getConstantValue(Instruction instr) {
   result = instr.(IntegerConstantInstruction).getValue().toInt() or
   result = getBinaryInstructionValue(instr) or
-  exists(UnaryInstruction unaryInstr, int src |
-    unaryInstr = instr and
-    src = getConstantValue(unaryInstr.getOperand()) and
-    (
-      unaryInstr instanceof NegateInstruction and result = neg(src)
-    )
-  ) or
+  result = neg(getConstantValue(instr.(NegateInstruction).getOperand())) or
   result = getConstantValue(instr.(CopyInstruction).getSourceValue()) or
   exists(PhiInstruction phi |
     phi = instr and

cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/constant/ConstantAnalysis.qll

@@ -6,13 +6,7 @@ language[monotonicAggregates]
 int getConstantValue(Instruction instr) {
   result = instr.(IntegerConstantInstruction).getValue().toInt() or
   result = getBinaryInstructionValue(instr) or
-  exists(UnaryInstruction unaryInstr, int src |
-    unaryInstr = instr and
-    src = getConstantValue(unaryInstr.getOperand()) and
-    (
-      unaryInstr instanceof NegateInstruction and result = neg(src)
-    )
-  ) or
+  result = neg(getConstantValue(instr.(NegateInstruction).getOperand())) or
   result = getConstantValue(instr.(CopyInstruction).getSourceValue()) or
   exists(PhiInstruction phi |
     phi = instr and