Skip to content

Commit caddec4

Browse files
Update alert messages
1 parent adcfdf1 commit caddec4

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

python/ql/src/Classes/CallsToInitDel/MissingCallToDel.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ where
2525
(
2626
// Simple case: the method that should be called is directly overridden
2727
mroStart = base.getScope() and
28-
msg = "This deletion method does not call $@, which may leave $@ not properly cleaned up."
28+
msg = "This delete method does not call $@, which may leave $@ not properly cleaned up."
2929
or
3030
// Only alert for a different mro base if there are no alerts for direct overrides
3131
not missingCallToSuperclassDel(base, _, base.getScope()) and
3232
msg =
33-
"This deletion method does not call $@, which follows it in the MRO of $@, leaving it not properly cleaned up."
33+
"This delete method does not call super().__del__, which may cause $@ to be missed during the cleanup of $@."
3434
)
3535
select base, msg, shouldCall, shouldCall.getQualifiedName(), mroStart, mroStart.getName()

python/ql/src/Classes/CallsToInitDel/MissingCallToInit.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ where
2929
// Only alert for a different mro base if there are no alerts for direct overrides
3030
not missingCallToSuperclassInit(base, _, base.getScope()) and
3131
msg =
32-
"This initialization method does not call $@, which follows it in the MRO of $@, leaving it partially initialized."
32+
"This initialization method does not call super().__init__, which may cause $@ to be missed during the initialization of $@."
3333
)
3434
select base, msg, shouldCall, shouldCall.getQualifiedName(), mroStart, mroStart.getName()

python/ql/src/Classes/CallsToInitDel/SuperclassInitCalledMultipleTimes.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ where
2626
multipleCallsToSuperclassInit(meth, subMulti) and
2727
calledMulti.getScope() = getADirectSuperclass+(subMulti.getScope())
2828
)
29-
select meth, "This initializer method calls $@ multiple times.", calledMulti,
29+
select meth, "This initialization method calls $@ multiple times.", calledMulti,
3030
calledMulti.getQualifiedName()

0 commit comments

Comments
 (0)