C++: Remove linker-awareness FPs

Author: calumgrant

cpp/ql/src/Likely Bugs/Format/WrongTypeFormatArguments.ql

@@ -152,6 +152,10 @@ predicate trivialConversion(ExpectedType expected, Type actual) {
  */
 int sizeof_IntType() { exists(IntType it | result = it.getSize()) }
 
+predicate functionHasUniqueArguments(Function fn) {
+  forall(Parameter p | p = fn.getAParameter() | count(p.getType().getUnspecifiedType()) = 1)
+}
+
 from FormattingFunctionCall ffc, int n, Expr arg, Type expected, Type actual
 where
   (
@@ -171,7 +175,8 @@ where
   not arg.isAffectedByMacro() and
   not arg.isFromUninstantiatedTemplate(_) and
   not actual.stripType() instanceof ErroneousType and
-  not arg.(Call).mayBeFromImplicitlyDeclaredFunction()
+  not arg.(Call).mayBeFromImplicitlyDeclaredFunction() and
+  functionHasUniqueArguments(ffc.getTarget())
 select arg,
   "This format specifier for type '" + expected.getName() + "' does not match the argument type '" +
     actual.getUnspecifiedType().getName() + "'."

cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Buildless/WrongTypeFormatArguments.expected

@@ -1,2 +1 @@
 | tests.c:7:18:7:18 | 1 | This format specifier for type 'char *' does not match the argument type 'int'. |
-| tests.c:29:27:29:27 | 1 | This format specifier for type 'char *' does not match the argument type 'int'. |