Fix ordering for definitionOf

hmac · hmac · commit cd3192e8f17d · 2021-08-31T15:42:06.000+01:00
Actually select the lexicographically least location, not the greatest.
diff --git a/ql/src/queries/analysis/Definitions.ql b/ql/src/queries/analysis/Definitions.ql
@@ -101,7 +101,7 @@ string constantQualifiedName(ConstantWriteAccess w) {
  */
 ConstantWriteAccess definitionOf(ConstantReadAccess r) {
   result =
-    max(ConstantWriteAccess w |
+    min(ConstantWriteAccess w |
       constantQualifiedName(w) = resolveConstant(r)
     |
       w order by w.getLocation().toString()

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ string constantQualifiedName(ConstantWriteAccess w) {`
`101`	`101`	`*/`
`102`	`102`	`ConstantWriteAccess definitionOf(ConstantReadAccess r) {`
`103`	`103`	`result =`
`104`		`- max(ConstantWriteAccess w \|`
	`104`	`+ min(ConstantWriteAccess w \|`
`105`	`105`	`constantQualifiedName(w) = resolveConstant(r)`
`106`	`106`	`\|`
`107`	`107`	`w order by w.getLocation().toString()`