C++: Remove default getAPrimaryQlClass().

criemen · criemen · commit cfe86bf53b50 · 2020-11-18T17:34:56.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/Element.qll b/cpp/ql/src/semmle/code/cpp/Element.qll
@@ -65,11 +65,10 @@ class ElementBase extends @element {
    * which they belong; for example, `AddExpr` is a primary class, but
    * `BinaryOperation` is not.
    *
-   * This predicate always has a result. If no primary class can be
-   * determined, the result is `"???"`. If multiple primary classes match,
-   * this predicate can have multiple results.
+   * This predicate can have multiple results if multiple primary classes match.
+   * For some elements, this predicate may not exist.
    */
-  string getAPrimaryQlClass() { result = "???" }
+  string getAPrimaryQlClass() { none() }
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -65,11 +65,10 @@ class ElementBase extends @element {`
`65`	`65`	* which they belong; for example, `AddExpr` is a primary class, but
`66`	`66`	* `BinaryOperation` is not.
`67`	`67`	`*`
`68`		`- * This predicate always has a result. If no primary class can be`
`69`		- * determined, the result is `"???"`. If multiple primary classes match,
`70`		`- * this predicate can have multiple results.`
	`68`	`+ * This predicate can have multiple results if multiple primary classes match.`
	`69`	`+ * For some elements, this predicate may not exist.`
`71`	`70`	`*/`
`72`		`- string getAPrimaryQlClass() { result = "???" }`
	`71`	`+ string getAPrimaryQlClass() { none() }`
`73`	`72`	`}`
`74`	`73`
`75`	`74`	`/**`