Skip to content

Commit d005d71

Browse files
committed
JS: address doc review
1 parent e4c8653 commit d005d71

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

javascript/ql/src/Security/CWE-640/HostHeaderPoisoningInEmailGeneration.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<p>
66
Using the HTTP Host header to construct a link in an email can facilitate phishing attacks and leak password reset tokens.
77
A malicious user can send an HTTP request to the targeted web site, but with a Host header that refers to his own web site.
8-
This means the emails will be sent out to potential victims, originating from a server they trust but with
8+
This means the emails will be sent out to potential victims, originating from a server they trust, but with
99
links leading to a malicious web site.
1010
</p>
1111
<p>

javascript/ql/src/Security/CWE-640/examples/HostHeaderPoisoningInEmailGeneration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ app.post('/resetpass', (req, res) => {
1414
from: 'webmaster@example.com',
1515
to: email,
1616
subject: 'Forgot password',
17-
text: `Forgot your password?. Click here to reset: https://${req.host}/resettoken/${token}`,
17+
text: `Click to reset password: https://${req.host}/resettoken/${token}`,
1818
});
1919
});

javascript/ql/src/Security/CWE-640/examples/HostHeaderPoisoningInEmailGenerationGood.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ app.post('/resetpass', (req, res) => {
1414
from: 'webmaster@example.com',
1515
to: email,
1616
subject: 'Forgot password',
17-
text: `Forgot your password?. Click here to reset: https://${config.hostname}/resettoken/${token}`,
17+
text: `Click to reset password: https://${config.hostname}/resettoken/${token}`,
1818
});
1919
});

0 commit comments

Comments
 (0)