Apply suggestions from code review

atorralba · Marcono1234 · atorralba · commit d10dbbdd9d16 · 2021-09-27T11:40:51.000+02:00
Co-authored-by: Marcono1234 &lt;Marcono1234@users.noreply.github.com&gt;
diff --git a/java/change-notes/2021-06-08-spel-injection-query.md b/java/change-notes/2021-06-08-spel-injection-query.md
@@ -1,2 +1,2 @@
 lgtm,codescanning
-* The query "Expression language injection (Spring)" (`java/spel-expression-injection`) has been promoted from experimental to the main query pack. Its results will now appear by default. This query was originally [submitted as an experimental query by @artem-smotrakov](https://github.com/github/codeql/pull/3291)
+* The query "Expression language injection (Spring)" (`java/spel-expression-injection`) has been promoted from experimental to the main query pack. Its results will now appear by default. This query was originally [submitted as an experimental query by @artem-smotrakov](https://github.com/github/codeql/pull/3291).
diff --git a/java/ql/src/semmle/code/java/frameworks/spring/SpringExpression.qll b/java/ql/src/semmle/code/java/frameworks/spring/SpringExpression.qll
@@ -22,7 +22,7 @@ class ExpressionParser extends RefType {
 }
 
 /**
- * The class `org.springframework.expression.spel.support."SimpleEvaluationContext$Builder`.
+ * The class `org.springframework.expression.spel.support.SimpleEvaluationContext$Builder`.
  */
 class SimpleEvaluationContextBuilder extends RefType {
   SimpleEvaluationContextBuilder() {
diff --git a/java/ql/src/semmle/code/java/security/SpelInjectionQuery.qll b/java/ql/src/semmle/code/java/security/SpelInjectionQuery.qll
@@ -54,7 +54,7 @@ private class SafeEvaluationContextFlowConfig extends DataFlow2::Configuration {
 }
 
 /**
- * A `ContextSource` that is safe from SpEL injection
+ * A `ContextSource` that is safe from SpEL injection.
  */
 private class SafeContextSource extends DataFlow::ExprNode {
   SafeContextSource() {

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`lgtm,codescanning`
`2`		-* The query "Expression language injection (Spring)" (`java/spel-expression-injection`) has been promoted from experimental to the main query pack. Its results will now appear by default. This query was originally [submitted as an experimental query by @artem-smotrakov](https://github.com/github/codeql/pull/3291)
	`2`	+* The query "Expression language injection (Spring)" (`java/spel-expression-injection`) has been promoted from experimental to the main query pack. Its results will now appear by default. This query was originally [submitted as an experimental query by @artem-smotrakov](https://github.com/github/codeql/pull/3291).
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class ExpressionParser extends RefType {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`/**`
`25`		- * The class `org.springframework.expression.spel.support."SimpleEvaluationContext$Builder`.
	`25`	+ * The class `org.springframework.expression.spel.support.SimpleEvaluationContext$Builder`.
`26`	`26`	`*/`
`27`	`27`	`class SimpleEvaluationContextBuilder extends RefType {`
`28`	`28`	`SimpleEvaluationContextBuilder() {`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ private class SafeEvaluationContextFlowConfig extends DataFlow2::Configuration {`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`/**`
`57`		- * A `ContextSource` that is safe from SpEL injection
	`57`	+ * A `ContextSource` that is safe from SpEL injection.
`58`	`58`	`*/`
`59`	`59`	`private class SafeContextSource extends DataFlow::ExprNode {`
`60`	`60`	`SafeContextSource() {`