C++: Remove implied conjunction.

MathiasVP · MathiasVP · commit d1eb77473718 · 2021-05-06T17:03:42.000+02:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-570/IncorrectAllocationErrorHandling.ql b/cpp/ql/src/experimental/Security/CWE/CWE-570/IncorrectAllocationErrorHandling.ql
@@ -191,8 +191,7 @@ predicate noThrowInTryBlock(NewOrNewArrayExpr newExpr, BadAllocCatchBlock catchB
       not convertedExprMayThrow(cand)
     ) and
     try.getACatchClause() = catchBlock and
-    newExpr.getEnclosingBlock().getEnclosingBlock*() = try.getStmt() and
-    not newMayThrow(newExpr)
+    newExpr.getEnclosingBlock().getEnclosingBlock*() = try.getStmt()
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -191,8 +191,7 @@ predicate noThrowInTryBlock(NewOrNewArrayExpr newExpr, BadAllocCatchBlock catchB`
`191`	`191`	`not convertedExprMayThrow(cand)`
`192`	`192`	`) and`
`193`	`193`	`try.getACatchClause() = catchBlock and`
`194`		`- newExpr.getEnclosingBlock().getEnclosingBlock*() = try.getStmt() and`
`195`		`- not newMayThrow(newExpr)`
	`194`	`+ newExpr.getEnclosingBlock().getEnclosingBlock*() = try.getStmt()`
`196`	`195`	`)`
`197`	`196`	`}`
`198`	`197`