Remove Protocol as UntrustedFlowSource

gagliardetto · gagliardetto · commit d252d6003f32 · 2021-07-15T16:20:33.000+02:00
diff --git a/ql/src/experimental/frameworks/Fiber.json b/ql/src/experimental/frameworks/Fiber.json
@@ -1,5 +1,6 @@
 {
    "Name": "Fiber",
+   "Preload": null,
    "Models": [
       {
          "Name": "TaintTracking",
@@ -929,17 +930,15 @@
                      }
                   },
                   {
-                     "Kind": "Func",
+                     "Kind": "Struct",
                      "Qualifier": {
                         "Path": "github.com/gofiber/fiber",
                         "Version": "v1.14.6",
-                        "ID": "TypeMethod-Ctx-Protocol",
-                        "Pos": [
-                           false,
-                           true
-                        ],
-                        "Flows": null,
-                        "Name": "Protocol"
+                        "ID": "Struct-Error",
+                        "TypeName": "Error",
+                        "Fields": {
+                           "Message": null
+                        }
                      }
                   },
                   {
@@ -1019,18 +1018,6 @@
                            "Value": null
                         }
                      }
-                  },
-                  {
-                     "Kind": "Struct",
-                     "Qualifier": {
-                        "Path": "github.com/gofiber/fiber",
-                        "Version": "v1.14.6",
-                        "ID": "Struct-Error",
-                        "TypeName": "Error",
-                        "Fields": {
-                           "Message": null
-                        }
-                     }
                   }
                ]
             }
diff --git a/ql/src/experimental/frameworks/Fiber.qll b/ql/src/experimental/frameworks/Fiber.qll
@@ -366,10 +366,6 @@ private module Fiber {
           methodName = "Path" and
           out.isResult()
           or
-          // signature: func (*Ctx).Protocol() string
-          methodName = "Protocol" and
-          out.isResult()
-          or
           // signature: func (*Ctx).Query(key string, defaultValue ...string) string
           methodName = "Query" and
           out.isResult()
diff --git a/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.go b/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.go

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"Name": "Fiber",`
	`3`	`+ "Preload": null,`
`3`	`4`	`"Models": [`
`4`	`5`	`{`
`5`	`6`	`"Name": "TaintTracking",`
`@@ -929,17 +930,15 @@`
`929`	`930`	`}`
`930`	`931`	`},`
`931`	`932`	`{`
`932`		`- "Kind": "Func",`
	`933`	`+ "Kind": "Struct",`
`933`	`934`	`"Qualifier": {`
`934`	`935`	`"Path": "github.com/gofiber/fiber",`
`935`	`936`	`"Version": "v1.14.6",`
`936`		`- "ID": "TypeMethod-Ctx-Protocol",`
`937`		`- "Pos": [`
`938`		`- false,`
`939`		`- true`
`940`		`- ],`
`941`		`- "Flows": null,`
`942`		`- "Name": "Protocol"`
	`937`	`+ "ID": "Struct-Error",`
	`938`	`+ "TypeName": "Error",`
	`939`	`+ "Fields": {`
	`940`	`+ "Message": null`
	`941`	`+ }`
`943`	`942`	`}`
`944`	`943`	`},`
`945`	`944`	`{`
`@@ -1019,18 +1018,6 @@`
`1019`	`1018`	`"Value": null`
`1020`	`1019`	`}`
`1021`	`1020`	`}`
`1022`		`- },`
`1023`		`- {`
`1024`		`- "Kind": "Struct",`
`1025`		`- "Qualifier": {`
`1026`		`- "Path": "github.com/gofiber/fiber",`
`1027`		`- "Version": "v1.14.6",`
`1028`		`- "ID": "Struct-Error",`
`1029`		`- "TypeName": "Error",`
`1030`		`- "Fields": {`
`1031`		`- "Message": null`
`1032`		`- }`
`1033`		`- }`
`1034`	`1021`	`}`
`1035`	`1022`	`]`
`1036`	`1023`	`}`