Stay on dataflow level

edvraa · owen-mc · commit d60d18a8d025 · 2021-06-17T09:23:26.000+01:00
diff --git a/ql/src/experimental/CWE-1004/AuthCookie.qll b/ql/src/experimental/CWE-1004/AuthCookie.qll
@@ -57,9 +57,9 @@ private predicate isAuthVariable(Expr expr) {
  */
 private class SetCookieSink extends DataFlow::Node {
   SetCookieSink() {
-    exists(CallExpr c |
-      c.getTarget().hasQualifiedName(package("net/http", ""), "SetCookie") and
-      this.asExpr() = c.getArgument(1)
+    exists(DataFlow::CallNode cn |
+      cn.getTarget().hasQualifiedName(package("net/http", ""), "SetCookie") and
+      this = cn.getArgument(1)
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,9 @@ private predicate isAuthVariable(Expr expr) {`
`57`	`57`	`*/`
`58`	`58`	`private class SetCookieSink extends DataFlow::Node {`
`59`	`59`	`SetCookieSink() {`
`60`		`- exists(CallExpr c \|`
`61`		`- c.getTarget().hasQualifiedName(package("net/http", ""), "SetCookie") and`
`62`		`- this.asExpr() = c.getArgument(1)`
	`60`	`+ exists(DataFlow::CallNode cn \|`
	`61`	`+ cn.getTarget().hasQualifiedName(package("net/http", ""), "SetCookie") and`
	`62`	`+ this = cn.getArgument(1)`
`63`	`63`	`)`
`64`	`64`	`}`
`65`	`65`	`}`