C++: Use ConditionDeclExpr in AnalysedExpr::isDef

jketema · jketema · commit d63b0946d98e · 2022-07-12T15:22:13.000+02:00
diff --git a/cpp/ql/lib/semmle/code/cpp/controlflow/Nullness.qll b/cpp/ql/lib/semmle/code/cpp/controlflow/Nullness.qll
@@ -171,8 +171,8 @@ class AnalysedExpr extends Expr {
     this.inCondition() and
     (
       this.(Assignment).getLValue() = v.getAnAccess() or
-      exists(Initializer i | this.getEnclosingStmt() = i.getEnclosingStmt() and v = i.getDeclaration())
-    ) 
+      this.(ConditionDeclExpr).getVariableAccess() = v.getAnAccess()
+    )
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -171,8 +171,8 @@ class AnalysedExpr extends Expr {`
`171`	`171`	`this.inCondition() and`
`172`	`172`	`(`
`173`	`173`	`this.(Assignment).getLValue() = v.getAnAccess() or`
`174`		`- exists(Initializer i \| this.getEnclosingStmt() = i.getEnclosingStmt() and v = i.getDeclaration())`
`175`		`- )`
	`174`	`+ this.(ConditionDeclExpr).getVariableAccess() = v.getAnAccess()`
	`175`	`+ )`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`/**`