rename maybeGetJoinArg maybeGetPathSuffix

Author: erik-krogh

javascript/ql/lib/semmle/javascript/security/dataflow/TaintedPathCustomizations.qll

@@ -513,16 +513,21 @@ module TaintedPath {
 
     override predicate blocks(boolean outcome, Expr e) {
       member = "relative" and
-      e = maybeGetJoinArg(pathCall.getArgument(1)).asExpr() and
+      e = maybeGetPathSuffix(pathCall.getArgument(1)).asExpr() and
       outcome = startsWith.getPolarity().booleanNot()
       or
       not member = "relative" and
-      e = maybeGetJoinArg(pathCall.getArgument(0)).asExpr() and
+      e = maybeGetPathSuffix(pathCall.getArgument(0)).asExpr() and
       outcome = startsWith.getPolarity()
     }
 
+    /**
+     * Gets the last argument to the given `path.join()` call,
+     * or the node itself if it is not a join call.
+     * Is used to get the suffix of the path.
+     */
     bindingset[e]
-    private DataFlow::Node maybeGetJoinArg(DataFlow::Node e) {
+    private DataFlow::Node maybeGetPathSuffix(DataFlow::Node e) {
       exists(DataFlow::CallNode call |
         call = NodeJSLib::Path::moduleMember("join").getACall() and e = call
       |