Skip to content

Commit dada49f

Browse files
Fix qldoc and tests
1 parent 9c3f4e2 commit dada49f

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

python/ql/lib/semmle/python/frameworks/Tornado.qll

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,13 @@ module Tornado {
437437
/** Gets a reference to the `tornado.websocket` module. */
438438
API::Node websocket() { result = Tornado::tornado().getMember("websocket") }
439439

440+
/** Provides models for the `tornado.websocket` module */
440441
module WebSocket {
442+
/**
443+
* Provides models for the `tornado.websocket.WebSocketHandler` class and subclasses.
444+
*
445+
* See https://www.tornadoweb.org/en/stable/websocket.html#tornado.websocket.WebSocketHandler.
446+
*/
441447
module WebSocketHandler {
442448
/** Gets a reference to the `tornado.websocket.WebSocketHandler` class or any subclass. */
443449
API::Node subclassRef() {
@@ -447,6 +453,7 @@ module Tornado {
447453
ModelOutput::getATypeNode("tornado.websocket.WebSocketHandler~Subclass").getASubclass*()
448454
}
449455

456+
/** A subclass of `tornado.websocket.WebSocketHandler`. */
450457
class WebSocketHandlerClass extends Web::RequestHandler::RequestHandlerClass {
451458
WebSocketHandlerClass() { this.getParent() = subclassRef().asSource().asExpr() }
452459

@@ -457,7 +464,7 @@ module Tornado {
457464
result.getName() = "open"
458465
}
459466

460-
/** Gets a function that could handle incoming websocket events, if any. */
467+
/** Gets a function that could handle incoming WebSocket events, if any. */
461468
Function getAWebSocketEventHandler() {
462469
result = this.getAMethod() and
463470
result.getName() =
@@ -580,7 +587,7 @@ module Tornado {
580587
override string getFramework() { result = "Tornado" }
581588
}
582589

583-
/** A request handler for WebSocket events */
590+
/** A request handler for WebSocket events. */
584591
private class TornadoWebSocketEventHandler extends Http::Server::RequestHandler::Range {
585592
TornadoWebSocketEventHandler() {
586593
exists(TornadoModule::WebSocket::WebSocketHandler::WebSocketHandlerClass cls |

python/ql/test/library-tests/frameworks/tornado/routing_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import tornado.web
22
import tornado.routing
3+
import tornado.websocket
34

45

56
class FooHandler(tornado.web.RequestHandler):
@@ -56,7 +57,7 @@ def get(self): # $ requestHandler
5657

5758
class WebSocket(tornado.websocket.WebSocketHandler):
5859
def open(self, x): # $ requestHandler routedParameter=x
59-
self.write_message("WebSocket open {}".format(x))
60+
self.write_message("WebSocket open {}".format(x))
6061

6162
def on_message(self, data): # $ requestHandler routedParameter=data
6263
self.write_message("WebSocket on_message {}".format(data))
@@ -74,7 +75,6 @@ def check_origin(self, origin): # $ requestHandler routedParameter=origin
7475
print("check_origin", origin)
7576
return True
7677

77-
7878

7979
def make_app():
8080
# see https://www.tornadoweb.org/en/stable/routing.html for even more examples

0 commit comments

Comments
 (0)