Skip to content

Commit dafcd59

Browse files
committed
add another indirect route-handler test
1 parent 43e5c02 commit dafcd59

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

javascript/ql/test/query-tests/Security/CWE-352/MissingCsrfMiddleware.expected

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
| MissingCsrfMiddlewareBad.js:7:9:7:22 | cookieParser() | This cookie middleware is serving a request handler $@ without CSRF protection. | MissingCsrfMiddlewareBad.js:10:26:12:1 | functio ... il"];\\n} | here |
22
| MissingCsrfMiddlewareBad.js:17:13:17:26 | cookieParser() | This cookie middleware is serving a request handler $@ without CSRF protection. | MissingCsrfMiddlewareBad.js:25:30:27:6 | errorCa ... \\n }) | here |
3+
| MissingCsrfMiddlewareBad.js:33:13:33:26 | cookieParser() | This cookie middleware is serving a request handler $@ without CSRF protection. | MissingCsrfMiddlewareBad.js:41:30:43:6 | errorCa ... \\n }) | here |
34
| csurf_api_example.js:42:37:42:50 | cookieParser() | This cookie middleware is serving a request handler $@ without CSRF protection. | csurf_api_example.js:42:53:45:3 | functio ... e')\\n } | here |
45
| csurf_example.js:18:9:18:22 | cookieParser() | This cookie middleware is serving a request handler $@ without CSRF protection. | csurf_example.js:31:40:34:1 | functio ... sed')\\n} | here |
56
| lusca_example.js:9:9:9:22 | cookieParser() | This cookie middleware is serving a request handler $@ without CSRF protection. | lusca_example.js:26:42:29:1 | functio ... sed')\\n} | here |

javascript/ql/test/query-tests/Security/CWE-352/MissingCsrfMiddlewareBad.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,19 @@ app.post('/changeEmail', function (req, res) {
2626
let newEmail = req.cookies["newEmail"];
2727
}));
2828
})
29+
30+
(function () {
31+
var app = express();
32+
33+
app.use(cookieParser());
34+
app.use(passport.authorize({ session: true }));
35+
36+
const errorCatch = (fn) =>
37+
(req, res, next) => {
38+
fn.call(this, req, res, next).catch((e) => console.log("Caught " + e));
39+
};
40+
41+
app.post('/changeEmail', errorCatch(async function (req, res) {
42+
let newEmail = req.cookies["newEmail"];
43+
}));
44+
})

0 commit comments

Comments
 (0)