C++: fix alias model for smart pointer setters

Robert Marsh · Robert Marsh · commit db85a215ab3b · 2021-05-18T13:16:22.000-07:00
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/SmartPointer.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/SmartPointer.qll
@@ -146,8 +146,7 @@ private class SmartPtrSetterFunction extends MemberFunction, AliasFunction, Side
   }
 
   private FunctionInput getPointerInput() {
-    exists(Parameter param0 |
-      param0 = this.getParameter(0) and
+    exists(Parameter param0 | param0 = this.getParameter(0) |
       (
         param0.getUnspecifiedType().(ReferenceType).getBaseType() instanceof SmartPtr and
         if this.getParameter(1).getUnspecifiedType() instanceof PointerType

Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,7 @@ private class SmartPtrSetterFunction extends MemberFunction, AliasFunction, Side`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`private FunctionInput getPointerInput() {`
`149`		`- exists(Parameter param0 \|`
`150`		`- param0 = this.getParameter(0) and`
	`149`	`+ exists(Parameter param0 \| param0 = this.getParameter(0) \|`
`151`	`150`	`(`
`152`	`151`	`param0.getUnspecifiedType().(ReferenceType).getBaseType() instanceof SmartPtr and`
`153`	`152`	`if this.getParameter(1).getUnspecifiedType() instanceof PointerType`