Skip to content

Commit dc45ba5

Browse files
committed
Java: update XXE qhelp with note on processing limits
1 parent 10172af commit dc45ba5

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

java/ql/src/Security/CWE/CWE-611/XXE.qhelp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ external entities. This query currently identifies vulnerable XML parsing from t
2525
The best way to prevent XXE attacks is to disable the parsing of any Document Type Declarations (DTDs) in untrusted data.
2626
If this is not possible you should disable the parsing of external general entities and external parameter entities.
2727
This improves security but the code will still be at risk of denial of service and server side request forgery attacks.
28+
Protection against denial of service attacks may also be implemented by setting entity expansion limits, which is done
29+
by default in recent JDK and JRE implementations.
2830
</p>
2931
</recommendation>
3032

@@ -64,6 +66,10 @@ Out-of-band data retrieval: Timur Yunusov &amp; Alexey Osipov, Black hat EU 2013
6466
Denial of service attack (Billion laughs):
6567
<a href="https://en.wikipedia.org/wiki/Billion_laughs">Billion Laughs.</a>
6668
</li>
69+
<li>
70+
The Java Tutorials:
71+
<a href="https://docs.oracle.com/javase/tutorial/jaxp/limits/limits.html">Processing Limit Definitions.</a>
72+
</li>
6773

6874
</references>
6975

0 commit comments

Comments
 (0)