github
diff --git a/‎…ugs/Leap Year/Adding365daysPerYear.qhelp‎ ‎…ugs/Leap Year/Adding365DaysPerYear.qhelp‎cpp/ql/src/Likely Bugs/Leap Year/Adding365daysPerYear.qhelp renamed to cpp/ql/src/Likely Bugs/Leap Year/Adding365DaysPerYear.qhelp b/‎…ugs/Leap Year/Adding365daysPerYear.qhelp‎ ‎…ugs/Leap Year/Adding365DaysPerYear.qhelp‎cpp/ql/src/Likely Bugs/Leap Year/Adding365daysPerYear.qhelp renamed to cpp/ql/src/Likely Bugs/Leap Year/Adding365DaysPerYear.qhelp
diff --git a/‎…y Bugs/Leap Year/Adding365daysPerYear.ql‎ ‎…y Bugs/Leap Year/Adding365DaysPerYear.ql‎cpp/ql/src/Likely Bugs/Leap Year/Adding365daysPerYear.ql renamed to cpp/ql/src/Likely Bugs/Leap Year/Adding365DaysPerYear.ql b/‎…y Bugs/Leap Year/Adding365daysPerYear.ql‎ ‎…y Bugs/Leap Year/Adding365DaysPerYear.ql‎cpp/ql/src/Likely Bugs/Leap Year/Adding365daysPerYear.ql renamed to cpp/ql/src/Likely Bugs/Leap Year/Adding365DaysPerYear.ql
diff --git a/‎cpp/ql/src/Likely Bugs/Leap Year/LeapYear.qll‎
Lines changed: 147 additions & 133 deletions b/‎cpp/ql/src/Likely Bugs/Leap Year/LeapYear.qll‎
Lines changed: 147 additions & 133 deletions
diff --git a/‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/Adding365DaysPerYear/Adding365daysPerYear.expected‎
Lines changed: 3 additions & 0 deletions b/‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/Adding365DaysPerYear/Adding365daysPerYear.expected‎
Lines changed: 3 additions & 0 deletions
diff --git a/‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/Adding365DaysPerYear/Adding365daysPerYear.qlref‎
Lines changed: 1 addition & 0 deletions b/‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/Adding365DaysPerYear/Adding365daysPerYear.qlref‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎…ely Bugs/Leap Year/AntiPattern2/test.cpp‎ ‎…/Leap Year/Adding365DaysPerYear/test.cpp‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern2/test.cpp renamed to cpp/ql/test/query-tests/Likely Bugs/Leap Year/Adding365DaysPerYear/test.cpp
Lines changed: 21 additions & 0 deletions b/‎…ely Bugs/Leap Year/AntiPattern2/test.cpp‎ ‎…/Leap Year/Adding365DaysPerYear/test.cpp‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern2/test.cpp renamed to cpp/ql/test/query-tests/Likely Bugs/Leap Year/Adding365DaysPerYear/test.cpp
Lines changed: 21 additions & 0 deletions
diff --git a/‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern2/Adding365daysPerYear.expected‎
Lines changed: 0 additions & 2 deletions b/‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern2/Adding365daysPerYear.expected‎
Lines changed: 0 additions & 2 deletions
diff --git a/‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern2/Adding365daysPerYear.qlref‎
Lines changed: 0 additions & 1 deletion b/‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern2/Adding365daysPerYear.qlref‎
Lines changed: 0 additions & 1 deletion
diff --git a/‎…edLeapYearAfterYearModification.expected‎ ‎…edLeapYearAfterYearModification.expected‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern1/UncheckedLeapYearAfterYearModification.expected renamed to cpp/ql/test/query-tests/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification/UncheckedLeapYearAfterYearModification.expected b/‎…edLeapYearAfterYearModification.expected‎ ‎…edLeapYearAfterYearModification.expected‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern1/UncheckedLeapYearAfterYearModification.expected renamed to cpp/ql/test/query-tests/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification/UncheckedLeapYearAfterYearModification.expected
diff --git a/‎…eckedLeapYearAfterYearModification.qlref‎ ‎…eckedLeapYearAfterYearModification.qlref‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern1/UncheckedLeapYearAfterYearModification.qlref renamed to cpp/ql/test/query-tests/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification/UncheckedLeapYearAfterYearModification.qlref b/‎…eckedLeapYearAfterYearModification.qlref‎ ‎…eckedLeapYearAfterYearModification.qlref‎cpp/ql/test/query-tests/Likely Bugs/Leap Year/AntiPattern1/UncheckedLeapYearAfterYearModification.qlref renamed to cpp/ql/test/query-tests/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification/UncheckedLeapYearAfterYearModification.qlref
@@ -0,0 +1,3 @@
+| test.cpp:173:2:173:52 | ... = ... | This arithmetic operation $@ uses a constant value of 365 ends up modifying the date/time located at $@, without considering leap year scenarios. | test.cpp:170:2:170:47 | ... += ... | ... += ... | test.cpp:173:2:173:52 | ... = ... | ... = ... |
+| test.cpp:174:2:174:46 | ... = ... | This arithmetic operation $@ uses a constant value of 365 ends up modifying the date/time located at $@, without considering leap year scenarios. | test.cpp:170:2:170:47 | ... += ... | ... += ... | test.cpp:174:2:174:46 | ... = ... | ... = ... |
+| test.cpp:193:2:193:24 | ... = ... | This arithmetic operation $@ uses a constant value of 365 ends up modifying the date/time located at $@, without considering leap year scenarios. | test.cpp:193:2:193:24 | ... = ... | ... = ... | test.cpp:193:2:193:24 | ... = ... | ... = ... |
@@ -0,0 +1 @@
+Likely Bugs/Leap Year/Adding365DaysPerYear.ql
@@ -176,3 +176,24 @@ void antipattern2()
 	// convert back to SYSTEMTIME for display or other usage
 	FileTimeToSystemTime(&ft, &st);
 }
+
+time_t mktime(struct tm *timeptr);
+struct tm *gmtime(const time_t *timer);
+
+time_t mkTime(int days)
+{
+	struct tm tm;
+	time_t t;
+
+	tm.tm_sec = 0;
+	tm.tm_min = 0;
+	tm.tm_hour = 0;
+	tm.tm_mday = 0;
+	tm.tm_mon = 0;
+	tm.tm_year = days / 365; // BAD
+	// ...
+
+	t = mktime(&tm); // convert tm -> time_t
+
+	return t;
+}
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+\| test.cpp:173:2:173:52 \| ... = ... \| This arithmetic operation $@ uses a constant value of 365 ends up modifying the date/time located at $@, without considering leap year scenarios. \| test.cpp:170:2:170:47 \| ... += ... \| ... += ... \| test.cpp:173:2:173:52 \| ... = ... \| ... = ... \|`
	`2`	`+\| test.cpp:174:2:174:46 \| ... = ... \| This arithmetic operation $@ uses a constant value of 365 ends up modifying the date/time located at $@, without considering leap year scenarios. \| test.cpp:170:2:170:47 \| ... += ... \| ... += ... \| test.cpp:174:2:174:46 \| ... = ... \| ... = ... \|`
	`3`	`+\| test.cpp:193:2:193:24 \| ... = ... \| This arithmetic operation $@ uses a constant value of 365 ends up modifying the date/time located at $@, without considering leap year scenarios. \| test.cpp:193:2:193:24 \| ... = ... \| ... = ... \| test.cpp:193:2:193:24 \| ... = ... \| ... = ... \|`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Likely Bugs/Leap Year/Adding365DaysPerYear.ql`