Merge pull request #4296 from hvitved/csharp/useless-upcast-nomagic

hvitved · web-flow · commit dff9f8264bfa · 2020-09-18T16:24:20.000+02:00
C#: Avoid bad magic in `UselessUpcast.ql`
diff --git a/csharp/ql/src/Language Abuse/UselessUpcast.ql b/csharp/ql/src/Language Abuse/UselessUpcast.ql
@@ -38,7 +38,7 @@ predicate hasInstanceCallable(ValueOrRefType t, InstanceCallable c, string name)
 }
 
 /** Holds if extension method `m` is a method on `t` with name `name`. */
-pragma[noinline]
+pragma[nomagic]
 predicate hasExtensionMethod(ValueOrRefType t, ExtensionMethod m, string name) {
   t.isImplicitlyConvertibleTo(m.getExtendedType()) and
   name = m.getName()

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ predicate hasInstanceCallable(ValueOrRefType t, InstanceCallable c, string name)`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	/** Holds if extension method `m` is a method on `t` with name `name`. */
`41`		`-pragma[noinline]`
	`41`	`+pragma[nomagic]`
`42`	`42`	`predicate hasExtensionMethod(ValueOrRefType t, ExtensionMethod m, string name) {`
`43`	`43`	`t.isImplicitlyConvertibleTo(m.getExtendedType()) and`
`44`	`44`	`name = m.getName()`