make the axios error catch match the non-error case

Author: erik-krogh

javascript/ql/src/semmle/javascript/frameworks/ClientRequests.qll

@@ -271,8 +271,7 @@ module ClientRequest {
       or
       responseType = getResponseType() and
       promise = false and
-      result =
-        getReturn().getPromisedError().getMember("response").getMember("data").getAnImmediateUse()
+      result = getReturn().getPromisedError().getMember("response").getAnImmediateUse()
     }
   }
 

javascript/ql/test/library-tests/frameworks/ClientRequests/ClientRequests.expected

@@ -298,4 +298,6 @@ test_getAResponseDataNode
 | tst.js:235:5:237:6 | needle. ... \\n    }) | tst.js:235:73:235:76 | body | json | false |
 | tst.js:286:20:286:55 | new Web ... :8080') | tst.js:291:44:291:53 | event.data | json | false |
 | tst.js:296:5:299:6 | axios({ ... \\n    }) | tst.js:296:5:299:6 | axios({ ... \\n    }) | json | true |
-| tst.js:296:5:299:6 | axios({ ... \\n    }) | tst.js:303:26:303:42 | err.response.data | json | false |
+| tst.js:296:5:299:6 | axios({ ... \\n    }) | tst.js:302:28:302:39 | err.response | json | false |
+| tst.js:296:5:299:6 | axios({ ... \\n    }) | tst.js:303:26:303:37 | err.response | json | false |
+| tst.js:296:5:299:6 | axios({ ... \\n    }) | tst.js:304:27:304:38 | err.response | json | false |

javascript/ql/test/library-tests/frameworks/ClientRequests/tst.js

@@ -301,6 +301,7 @@ function moreAxios() {
         (err) => {
             const status = err.response.status;
             const data = err.response.data;
+            const agent = err.response.headers.useragent;
         }
     );
 }