Make preds private, autoformat

Author: AndreiDiaconu1

csharp/ql/src/semmle/code/csharp/ir/implementation/raw/internal/IRConstruction.qll

@@ -17,7 +17,6 @@ TranslatedElement getInstructionTranslatedElement(Instruction instruction) {
 }
 
 InstructionTag getInstructionTag(Instruction instruction) { instruction = MkInstruction(_, result) }
-
 import Cached
 
 cached
@@ -317,7 +316,6 @@ private module Cached {
   cached
   Language::BuiltInOperation getInstructionBuiltInOperation(Instruction instr) { none() }
 }
-
 import CachedForDebugging
 
 cached

csharp/ql/src/semmle/code/csharp/ir/implementation/raw/internal/TranslatedElement.qll

@@ -75,14 +75,12 @@ private predicate ignoreExprAndDescendants(Expr expr) {
   expr instanceof LocalVariableDeclExpr and
   expr.getParent() instanceof ForeachStmt
   or
-  (
-    // recursive case
-    ignoreExprAndDescendants(getRealParent(expr)) and 
-    // The two children of an `AssignOperation` should not be ignored, but since they are also
-    // descendants of an orphan node (the expanded form of the `AssignOperation` is also retrieved by 
-    // the extractor, which is rooted in an AST node without parents) they would be
-    not expr.getParent() instanceof AssignOperation
-  )
+  // recursive case
+  ignoreExprAndDescendants(getRealParent(expr)) and
+  // The two children of an `AssignOperation` should not be ignored, but since they are also
+  // descendants of an orphan node (the expanded form of the `AssignOperation` is also retrieved by
+  // the extractor, which is rooted in an AST node without parents) they would be
+  not expr.getParent() instanceof AssignOperation
 }
 
 /**
@@ -177,7 +175,7 @@ private predicate usedAsCondition(Expr expr) {
 /**
  * Holds if we should have a `Load` instruction for `expr` when generating the IR.
  */
-predicate mayNeedLoad(Expr expr) {
+private predicate mayNeedLoad(Expr expr) {
   expr instanceof AssignableRead
   or
   // We need an extra load for the `PointerIndirectionExpr`
@@ -195,7 +193,7 @@ predicate needsLoad(Expr expr) {
 /**
  * Holds if we should ignore the `Load` instruction for `expr` when generating IR.
  */
-predicate ignoreLoad(Expr expr) {
+private predicate ignoreLoad(Expr expr) {
   // No load needed for the qualifier
   // in an array access
   expr = any(ArrayAccess aa).getQualifier()
@@ -219,12 +217,12 @@ predicate ignoreLoad(Expr expr) {
   // given by a single `VariableAddress` instruction.
   expr = any(FieldAccess fa).getQualifier() and
   expr = any(VariableAccess va |
-    va.getType().isValueType() and
-    not va.getTarget() = any(Parameter p | p.isOutOrRef() or p.isIn())
-  )
+      va.getType().isValueType() and
+      not va.getTarget() = any(Parameter p | p.isOutOrRef() or p.isIn())
+    )
   or
   // If expr is passed as an `out,`ref` or `in` argument,
-  // no load should take place since we pass the address, not the 
+  // no load should take place since we pass the address, not the
   // value of the variable
   expr.(AssignableAccess).isOutOrRefArgument()
   or

csharp/ql/src/semmle/code/csharp/ir/implementation/raw/internal/TranslatedExpr.qll

@@ -853,7 +853,7 @@ class TranslatedNonFieldVariableAccess extends TranslatedVariableAccess {
     else result = this.getInstruction(AddressTag())
   }
 
-  override Instruction getInstructionOperand(InstructionTag tag, OperandTag operandTag) { 
+  override Instruction getInstructionOperand(InstructionTag tag, OperandTag operandTag) {
     result = TranslatedVariableAccess.super.getInstructionOperand(tag, operandTag)
   }
 

csharp/ql/src/semmle/code/csharp/ir/implementation/raw/internal/TranslatedStmt.qll

@@ -961,7 +961,9 @@ class TranslatedFixedStmt extends TranslatedStmt {
 
   override Instruction getChildSuccessor(TranslatedElement child) {
     exists(int id |
-      child = this.getDecl(id) and id < this.noDecls() - 1 and result = this.getDecl(id + 1).getFirstInstruction()
+      child = this.getDecl(id) and
+      id < this.noDecls() - 1 and
+      result = this.getDecl(id + 1).getFirstInstruction()
     )
     or
     child = this.getDecl(this.noDecls() - 1) and result = this.getBody().getFirstInstruction()

csharp/ql/src/semmle/code/csharp/ir/internal/IRCSharpLanguage.qll

@@ -29,6 +29,7 @@ class BuiltInOperation extends TBuiltInOperation {
 
 class ClassDerivation extends MkClassDerivation {
   Class baseClass;
+
   Class derivedClass;
 
   ClassDerivation() { this = MkClassDerivation(baseClass, derivedClass) }