CPP: Add a test of ArrayArgSizeMismatch.ql.

Author: geoffw0

cpp/ql/test/query-tests/Likely Bugs/Conversion/ArrayArgSizeMismatch/ArrayArgSizeMismatch.expected

@@ -0,0 +1,2 @@
+| test.cpp:24:4:24:7 | arr3 | Array of size 3 passed to $@ which expects an array of size 4. | test.cpp:8:6:8:6 | g | g |
+| test.cpp:40:9:40:12 | data | Array of size 0 passed to $@ which expects an array of size 4. | test.cpp:9:6:9:6 | h | h |

cpp/ql/test/query-tests/Likely Bugs/Conversion/ArrayArgSizeMismatch/ArrayArgSizeMismatch.qlref

@@ -0,0 +1 @@
+Likely Bugs/Conversion/ArrayArgSizeMismatch.ql

cpp/ql/test/query-tests/Likely Bugs/Conversion/ArrayArgSizeMismatch/test.cpp

@@ -0,0 +1,49 @@
+
+typedef unsigned long size_t;
+void *malloc(size_t size);
+
+#define NUM (4)
+
+void f(int *vs);
+void g(int vs[4]);
+void h(float fs[NUM]);
+
+struct myStruct
+{
+	unsigned int num;
+	float data[0];
+};
+
+void test(float f3[3], float f4[4], float f5[5], float *fp)
+{
+	int arr3[3], arr4[4], arr5[5];
+
+	f(arr3); // GOOD
+	f(arr4); // GOOD
+	f(arr5); // GOOD
+	g(arr3); // BAD
+	g(arr4); // GOOD
+	g(arr5); // GOOD
+
+	h(f3); // BAD [NOT DETECTED]
+	h(f4); // GOOD
+	h(f5); // GOOD
+	h(fp); // GOOD
+
+	{
+		// variable size struct
+		myStruct *ms;
+
+		ms = (myStruct *)malloc(sizeof(myStruct) + (4 * sizeof(float)));
+		ms->num  = 4;
+		ms->data[0] = ms->data[1] = ms->data[2] = ms->data[3] = 0;
+		h(ms->data); // GOOD [FALSE POSITIVE]
+	}
+	
+	{
+		// char array
+		char ca[4 * sizeof(int)];
+		
+		g((int *)ca); // GOOD
+	}
+};