JS: Remove use of types in Electron model

asgerf · asgerf · commit e2d428df7f9c · 2025-06-02T14:33:02.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/Electron.qll b/javascript/ql/lib/semmle/javascript/frameworks/Electron.qll
@@ -46,9 +46,7 @@ module Electron {
    */
   private class BrowserObjectByType extends BrowserObject {
     BrowserObjectByType() {
-      exists(string tp | tp = "BrowserWindow" or tp = "BrowserView" |
-        this.asExpr().getType().hasUnderlyingType("electron", tp)
-      )
+      this.(DataFlow::SourceNode).hasUnderlyingType("electron", ["BrowserWindow", "BrowserView"])
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,7 @@ module Electron {`
`46`	`46`	`*/`
`47`	`47`	`private class BrowserObjectByType extends BrowserObject {`
`48`	`48`	`BrowserObjectByType() {`
`49`		`- exists(string tp \| tp = "BrowserWindow" or tp = "BrowserView" \|`
`50`		`- this.asExpr().getType().hasUnderlyingType("electron", tp)`
`51`		`- )`
	`49`	`+ this.(DataFlow::SourceNode).hasUnderlyingType("electron", ["BrowserWindow", "BrowserView"])`
`52`	`50`	`}`
`53`	`51`	`}`
`54`	`52`