Apply suggestions from code review

atorralba · aschackmull · atorralba · commit e442e50e6bec · 2022-01-19T16:43:48.000+01:00
Co-authored-by: Anders Schack-Mulligen &lt;aschackmull@users.noreply.github.com&gt;
diff --git a/java/ql/lib/semmle/code/java/security/UnsafeCertTrustQuery.qll b/java/ql/lib/semmle/code/java/security/UnsafeCertTrustQuery.qll
@@ -60,6 +60,6 @@ private class SafeSetEndpointIdentificationAlgorithm extends MethodAccess {
     this.getMethod().hasName("setEndpointIdentificationAlgorithm") and
     this.getMethod().getDeclaringType() instanceof SSLParameters and
     not this.getArgument(0) instanceof NullLiteral and
-    not this.getArgument(0).(CompileTimeConstantExpr).getStringValue().length() = 0
+    not this.getArgument(0).(CompileTimeConstantExpr).getStringValue() = ""
   }
 }
diff --git a/java/ql/src/Security/CWE/CWE-273/UnsafeCertTrust.ql b/java/ql/src/Security/CWE/CWE-273/UnsafeCertTrust.ql
@@ -20,4 +20,4 @@ where
   exists(SslEndpointIdentificationFlowConfig config |
     config.hasFlowTo(DataFlow::exprNode(unsafeTrust))
   )
-select unsafeTrust, "Unsafe configuration of trusted certificates"
+select unsafeTrust, "Unsafe configuration of trusted certificates."

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,6 @@ private class SafeSetEndpointIdentificationAlgorithm extends MethodAccess {`
`60`	`60`	`this.getMethod().hasName("setEndpointIdentificationAlgorithm") and`
`61`	`61`	`this.getMethod().getDeclaringType() instanceof SSLParameters and`
`62`	`62`	`not this.getArgument(0) instanceof NullLiteral and`
`63`		`- not this.getArgument(0).(CompileTimeConstantExpr).getStringValue().length() = 0`
	`63`	`+ not this.getArgument(0).(CompileTimeConstantExpr).getStringValue() = ""`
`64`	`64`	`}`
`65`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,4 +20,4 @@ where`
`20`	`20`	`exists(SslEndpointIdentificationFlowConfig config \|`
`21`	`21`	`config.hasFlowTo(DataFlow::exprNode(unsafeTrust))`
`22`	`22`	`)`
`23`		`-select unsafeTrust, "Unsafe configuration of trusted certificates"`
	`23`	`+select unsafeTrust, "Unsafe configuration of trusted certificates."`