C++: Add testcase for false positive.

criemen · criemen · commit e68352bcdee2 · 2020-11-25T10:40:33.000+01:00
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/PointlessComparison/PointlessComparison.expected b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/PointlessComparison/PointlessComparison.expected
@@ -50,4 +50,5 @@
 | PointlessComparison.cpp:43:6:43:29 | ... >= ... | Comparison is always true because ... >> ... >= 140737488355327.5. |
 | PointlessComparison.cpp:44:6:44:28 | ... >= ... | Comparison is always true because ... >> ... >= 140737488355327.5. |
 | RegressionTests.cpp:57:7:57:22 | ... <= ... | Comparison is always true because * ... <= 4294967295. |
+| RegressionTests.cpp:125:7:125:11 | ... > ... | Comparison is always false because x <= 0. |
 | Templates.cpp:9:10:9:24 | ... <= ... | Comparison is always true because local <= 32767. |
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/PointlessComparison/RegressionTests.cpp b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/PointlessComparison/RegressionTests.cpp
@@ -116,3 +116,11 @@ void negativeZero4(int val) {
   if (val == 0) // GOOD [NO LONGER REPORTED]
     ;
 }
+
+void f(int *const &ref_to_ptr);
+
+void testTempObject() {
+  int x = 0;
+  f(&x);
+  if (x > 0) {} // BAD [FALSE POSITIVE]
+}

Original file line number	Diff line number	Diff line change
`@@ -116,3 +116,11 @@ void negativeZero4(int val) {`
`116`	`116`	`if (val == 0) // GOOD [NO LONGER REPORTED]`
`117`	`117`	`;`
`118`	`118`	`}`
	`119`	`+`
	`120`	`+void f(int *const &ref_to_ptr);`
	`121`	`+`
	`122`	`+void testTempObject() {`
	`123`	`+ int x = 0;`
	`124`	`+ f(&x);`
	`125`	`+ if (x > 0) {} // BAD [FALSE POSITIVE]`
	`126`	`+}`