Merge pull request #2228 from jbj/DefaultTaintTracking-getASTVariable

Dave Bartolomeo · web-flow · commit e6f632b44e7c · 2019-10-31T17:00:49.000-07:00
C++: Use getASTVariable in DefaultTaintTracking
diff --git a/cpp/ql/src/semmle/code/cpp/ir/dataflow/DefaultTaintTracking.qll b/cpp/ql/src/semmle/code/cpp/ir/dataflow/DefaultTaintTracking.qll
@@ -37,7 +37,7 @@ private class DefaultTaintTrackingCfg extends DataFlow::Configuration {
 }
 
 private predicate accessesVariable(CopyInstruction copy, Variable var) {
-  exists(VariableAddressInstruction va | va.getVariable().getAST() = var |
+  exists(VariableAddressInstruction va | va.getASTVariable() = var |
     copy.(StoreInstruction).getDestinationAddress() = va
     or
     copy.(LoadInstruction).getSourceAddress() = va

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ private class DefaultTaintTrackingCfg extends DataFlow::Configuration {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`private predicate accessesVariable(CopyInstruction copy, Variable var) {`
`40`		`- exists(VariableAddressInstruction va \| va.getVariable().getAST() = var \|`
	`40`	`+ exists(VariableAddressInstruction va \| va.getASTVariable() = var \|`
`41`	`41`	`copy.(StoreInstruction).getDestinationAddress() = va`
`42`	`42`	`or`
`43`	`43`	`copy.(LoadInstruction).getSourceAddress() = va`