Skip to content

Commit e859a80

Browse files
authored
Update docs on CodeQL design patterns
1 parent a62c334 commit e859a80

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

docs/ql-design-patterns.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,3 +76,5 @@ If you only had an `abstract class EscapeFunction { ... }`, then `JsEscapeFuncti
7676
## Importing all subclasses of abstract base class
7777

7878
When providing an abstract class, you should ensure that all subclasses are included when the abstract class is (unless you have good reason not to). Otherwise you risk having different meanings of the abstract class depending on what you happen to import.
79+
80+
One example where this _does not_ apply: `DataFlow::Configuration` and its variants are abstract, but we generally do not want to import all configurations into the same scope at once.

0 commit comments

Comments
 (0)