Merge pull request #7831 from RasmusWL/printast-remove-regexp

Python: Remove `RegExpTerm` from PrintAST

Author: RasmusWL

python/ql/lib/semmle/python/PrintAst.qll

@@ -53,9 +53,6 @@ private newtype TPrintAstNode =
     shouldPrint(list.getAnItem(), _) and
     not list = any(Module mod).getBody() and
     not forall(AstNode child | child = list.getAnItem() | isNotNeeded(child))
-  } or
-  TRegExpTermNode(RegExpTerm term) {
-    exists(StrConst str | term.getRootTerm() = getParsedRegExp(str) and shouldPrint(str, _))
   }
 
 /**
@@ -430,32 +427,6 @@ class ParameterNode extends AstElementNode {
  */
 class StrConstNode extends AstElementNode {
   override StrConst element;
-
-  override PrintAstNode getChild(int childIndex) {
-    childIndex = 0 and result.(RegExpTermNode).getTerm() = getParsedRegExp(element)
-  }
-}
-
-/**
- * A print node for a regular expression term.
- */
-class RegExpTermNode extends TRegExpTermNode, PrintAstNode {
-  RegExpTerm term;
-
-  RegExpTermNode() { this = TRegExpTermNode(term) }
-
-  /** Gets the `RegExpTerm` for this node. */
-  RegExpTerm getTerm() { result = term }
-
-  override PrintAstNode getChild(int childIndex) {
-    result.(RegExpTermNode).getTerm() = term.getChild(childIndex)
-  }
-
-  override string toString() {
-    result = "[" + strictconcat(term.getPrimaryQLClass(), " | ") + "] " + term.toString()
-  }
-
-  override Location getLocation() { result = term.getLocation() }
 }
 
 /**

python/ql/src/change-notes/2021-01-19-remove-regexp-from-printast.md

@@ -0,0 +1,4 @@
+---
+category: fix
+---
+* The [View AST functionality](https://codeql.github.com/docs/codeql-for-visual-studio-code/exploring-the-structure-of-your-source-code/) no longer prints detailed information about regular expressions, greatly improving performance.