getAStrictAncestor

Author: kaspersv

java/ql/src/Language Abuse/UselessTypeTest.ql

@@ -18,7 +18,7 @@ from InstanceOfExpr ioe, RefType t, RefType ct
 where
   t = ioe.getExpr().getType() and
   ct = ioe.getCheckedType() and
-  ct = t.getAStrictAncestor()
+  ct = t.getAStrictAncestorI()
 select ioe,
   "There is no need to test whether an instance of $@ is also an instance of $@ - it always is.", t,
   t.getName(), ct, ct.getName()

java/ql/src/Language Abuse/UselessUpcast.ql

@@ -65,7 +65,7 @@ where
     src = cse.getExpr().getType() and
     dest = cse.getType()
   ) and
-  dest = src.getAStrictAncestor() and
+  dest = src.getAStrictAncestorI() and
   not usefulUpcast(e)
 select e, "There is no need to upcast from $@ to $@ - the conversion can be done implicitly.", src,
   src.getName(), dest, dest.getName()

java/ql/src/Likely Bugs/Finalization/NullifiedSuperFinalize.ql

@@ -17,7 +17,7 @@ from FinalizeMethod m, Class c, FinalizeMethod mSuper, Class cSuper
 where
   m.getDeclaringType() = c and
   mSuper.getDeclaringType() = cSuper and
-  c.getAStrictAncestor() = cSuper and
+  c.getAStrictAncestorI() = cSuper and
   not cSuper instanceof TypeObject and
   not exists(m.getBody().getAChild())
 select m, "Finalize in " + c.getName() + " nullifies finalize in " + cSuper.getName() + "."

java/ql/src/Likely Bugs/Serialization/IncorrectSerialVersionUID.ql

@@ -21,5 +21,5 @@ where
     not f.isStatic() or
     not f.getType().hasName("long")
   ) and
-  f.getDeclaringType().getAStrictAncestor() instanceof TypeSerializable
+  f.getDeclaringType().getAStrictAncestorI() instanceof TypeSerializable
 select f, "'serialVersionUID' should be final, static, and of type long."

java/ql/src/Likely Bugs/Serialization/NonSerializableField.ql

@@ -78,7 +78,7 @@ predicate exceptions(Class c, Field f) {
     f.isStatic()
     or
     // Classes that implement `Externalizable` completely take over control during serialization.
-    externalizable(c.getAStrictAncestor())
+    externalizable(c.getAStrictAncestorI())
     or
     // Stateless session beans are not normally serialized during their usual life-cycle
     // but are forced by their expected supertype to be serializable.
@@ -93,7 +93,7 @@ predicate exceptions(Class c, Field f) {
 from Class c, Field f, string reason
 where
   c.fromSource() and
-  c.getAStrictAncestor() instanceof TypeSerializable and
+  c.getAStrictAncestorI() instanceof TypeSerializable and
   f.getDeclaringType() = c and
   not exceptions(c, f) and
   reason = nonSerialReason(f.getType())

java/ql/src/Performance/InnerClassCouldBeStatic.ql

@@ -22,7 +22,7 @@ pragma[nomagic]
 predicate inherits(Class c, Field f) {
   f = c.getAField()
   or
-  not f.isPrivate() and c.getAStrictAncestor().getAField() = f
+  not f.isPrivate() and c.getAStrictAncestorI().getAField() = f
 }
 
 /**

java/ql/src/Security/CWE/CWE-833/LockOrderInconsistency.ql

@@ -134,7 +134,7 @@ predicate inDifferentBranches(MethodCall ma1, MethodCall ma2) {
 /** The method access `ma` occurs in method `runnable`, which is an implementation of `Runnable.run()`. */
 predicate inRunnable(MethodCall ma, Method runnable) {
   runnable.getName() = "run" and
-  runnable.getDeclaringType().getAStrictAncestor().hasQualifiedName("java.lang", "Runnable") and
+  runnable.getDeclaringType().getAStrictAncestorI().hasQualifiedName("java.lang", "Runnable") and
   ma.getEnclosingCallable() = runnable
 }
 

java/ql/src/Violations of Best Practice/Magic Constants/MagicConstantsString.ql

@@ -52,7 +52,7 @@ predicate trivialContext(Literal e) {
   or
   // Message in an exception.
   exists(ClassInstanceExpr constr |
-    constr.getType().(RefType).getAStrictAncestor().hasName("Exception") and
+    constr.getType().(RefType).getAStrictAncestorI().hasName("Exception") and
     e = constr.getArgument(0)
   )
 }

java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverridesNames.ql

@@ -65,7 +65,7 @@ where
   ) and
   not exists(Method mid |
     confusing(m1, mid) and
-    mid.getDeclaringType().getAStrictAncestor() = m2.getDeclaringType()
+    mid.getDeclaringType().getAStrictAncestorI() = m2.getDeclaringType()
   ) and
   not exists(Method notConfusing |
     notConfusing.getDeclaringType() = m1.getDeclaringType() and