Skip to content

Commit ed5e2f3

Browse files
committed
It turns out that the bminor/bash alert spewage was caused by
a bug in the extractor, which is verified fixed in the next release. Reverting query to its original form.
1 parent 07ee9be commit ed5e2f3

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

cpp/ql/src/Likely Bugs/Underspecified Functions/TooManyArguments.ql

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* that the code does not follow the author's intent.
66
* @kind problem
77
* @problem.severity warning
8-
* @precision high
8+
* @precision very-high
99
* @id cpp/futile-params
1010
* @tags correctness
1111
* maintainability
@@ -34,7 +34,6 @@ predicate isCompiledAsC(Function f) {
3434
from FunctionCall fc, Function f
3535
where
3636
f = fc.getTarget() and
37-
f.getNumberOfParameters() = 0 and
3837
not f.isVarargs() and
3938
hasZeroParamDecl(f) and
4039
isCompiledAsC(f) and

cpp/ql/test/query-tests/Likely Bugs/Underspecified Functions/test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ void test(int *argv[]) {
3838

3939
int x;
4040
declared_empty_defined_with(&x); // BAD
41-
declared_empty_defined_with(3, &x); // BAD [NOT DETECTED]
41+
declared_empty_defined_with(3, &x); // BAD
4242

4343
not_declared_defined_with(-1, 0, 2U); // GOOD
4444
not_declared_defined_with(4LL, 0, 2.5e9f); // BAD

0 commit comments

Comments
 (0)