Skip to content

Commit edcd2dd

Browse files
authored
Merge pull request #4878 from shati-patel/docs-pullquotes
Docs: Change remaining notes to "pull-quote" directives
2 parents 2702b65 + 8c72451 commit edcd2dd

File tree

9 files changed

+22
-12
lines changed

9 files changed

+22
-12
lines changed

docs/codeql/codeql-cli/creating-codeql-query-suites.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ mapping with (usually) a single key. The instructions are executed in the order
1616
they appear in the query suite definition. After all the instructions in the
1717
suite definition have been executed, the result is a set of selected queries.
1818

19-
.. note::
19+
.. pull-quote:: Note
2020

2121
Any custom queries that you want to add to a query suite must be in a :doc:`QL
2222
pack <about-ql-packs>` and contain the correct query metadata.
@@ -54,7 +54,7 @@ queries using:
5454

5555
- qlpack: <qlpack-name>
5656

57-
.. note::
57+
.. pull-quote:: Note
5858

5959
When pathnames appear in query suite definitions, they must always
6060
be given with a forward slash, ``/``, as a directory separator.

docs/codeql/codeql-language-guides/hash-consing-and-value-numbering.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ The value numbering library exposes its interface primarily through the ``GVN``
5454

5555
To get the ``GVN`` of an ``Expr``, use the ``globalValueNumber`` predicate.
5656

57-
.. note::
57+
.. pull-quote:: Note
5858

5959
While the ``GVN`` class has ``toString`` and ``getLocation`` methods, these are only provided as debugging aids. They give the ``toString`` and ``getLocation`` of an arbitrary ``Expr`` within the set.
6060

@@ -90,7 +90,7 @@ The hash consing API
9090

9191
The hash consing library exposes its interface primarily through the ``HashCons`` class. Each instance of ``HashCons`` represents a set of expressions within one function that have the same syntax (including referring to the same variables). To get an expression in the set represented by a particular ``HashCons``, use the ``getAnExpr()`` member predicate.
9292

93-
.. note::
93+
.. pull-quote:: Note
9494

9595
While the ``HashCons`` class has ``toString`` and ``getLocation`` methods, these are only provided as debugging aids. They give the ``toString`` and ``getLocation`` of an arbitrary ``Expr`` within the set.
9696

docs/codeql/ql-language-reference/annotations.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,8 @@ change this definition. In this case, ``hasName`` should be final:
203203

204204
**Available for**: |classes|
205205

206-
.. important::
206+
.. pull-quote:: Important
207+
207208
This annotation is deprecated. Instead of annotating a name with ``library``, put it in a
208209
private (or privately imported) module.
209210

docs/codeql/ql-language-reference/evaluation-of-ql-programs.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,9 @@ To do this, you can use the following mechanisms:
9696
:ref:`binds <predicate-binding>` all its arguments.
9797
Therefore, if you :ref:`call <calls>` a predicate on a variable, the variable becomes bound.
9898

99-
.. important:: If a predicate uses non-standard binding sets, then it does **not** always bind
99+
.. pull-quote:: Important
100+
101+
If a predicate uses non-standard binding sets, then it does **not** always bind
100102
all its arguments. In such a case, whether the predicate call binds a specific argument
101103
depends on which other arguments are bound, and what the binding sets say about the
102104
argument in question. For more information, see ":ref:`binding-sets`."

docs/codeql/ql-language-reference/expressions.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,8 @@ The following table lists some examples of different forms of ``any`` expression
552552
| ``any(int i | i = [0 .. 3] | i * i)`` | the integers ``0``, ``1``, ``4``, and ``9`` |
553553
+------------------------------------------+-------------------------------------------------+
554554

555-
.. note::
555+
.. pull-quote:: Note
556+
556557
There is also a `built-in predicate <ql-language-specification#non-member-built-ins>`_
557558
``any()``. This is a predicate that always holds.
558559

docs/codeql/ql-language-reference/formulas.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,8 @@ The following query selects files that are not HTML files.
318318
where not f.getFileType().isHtml()
319319
select f
320320
321-
.. note::
321+
.. pull-quote:: Note
322+
322323
You should be careful when using ``not`` in a recursive definition, as this could lead to
323324
non-monotonic recursion. For more information, ":ref:`non-monotonic-recursion`."
324325

docs/codeql/ql-language-reference/predicates.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ When defining a predicate, you should specify:
5555
argument type and an identifier for the argument variable.
5656
#. The predicate body itself. This is a logical formula enclosed in braces.
5757

58-
.. note::
58+
.. pull-quote:: Note
59+
5960
An :ref:`abstract` or :ref:`external` predicate has no body. To define such a predicate,
6061
end the predicate definition with a semicolon (``;``) instead.
6162

docs/codeql/ql-language-reference/types.rst

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,9 @@ value, namely 2.
366366
It inherits member predicates from ``OneTwo`` and ``TwoThree``. It also (indirectly) inherits
367367
from ``OneTwoThree`` and ``int``.
368368

369-
.. note:: If a subclass inherits multiple definitions for the same predicate name, then it
369+
.. pull-quote:: Note
370+
371+
If a subclass inherits multiple definitions for the same predicate name, then it
370372
must :ref:`override <overriding-member-predicates>` those definitions to avoid ambiguity.
371373
:ref:`Super expressions <super>` are often useful in this situation.
372374

@@ -397,7 +399,9 @@ in the characteristic predicate of a class.
397399
Algebraic datatypes
398400
*******************
399401

400-
.. note:: The syntax for algebraic datatypes is considered experimental and is subject to
402+
.. pull-quote:: Note
403+
404+
The syntax for algebraic datatypes is considered experimental and is subject to
401405
change. However, they appear in the `standard QL libraries <https://github.com/github/codeql>`_
402406
so the following sections should help you understand those examples.
403407

docs/codeql/writing-codeql-queries/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ Get to know more about queries and learn some key query-writing skills by solvin
1212
.. toctree::
1313
:hidden:
1414

15-
ql-tutorials
1615
codeql-queries
16+
ql-tutorials

0 commit comments

Comments
 (0)