revert change to return-type

erik-krogh · erik-krogh · commit edebbd640ed9 · 2020-09-21T10:18:22.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/HTTP.qll b/javascript/ql/src/semmle/javascript/frameworks/HTTP.qll
@@ -661,7 +661,8 @@ module HTTP {
         )
       }
 
-      override RouteHandlerCandidate getRouteHandler(DataFlow::SourceNode access) {
+      override DataFlow::SourceNode getRouteHandler(DataFlow::SourceNode access) {
+        result instanceof RouteHandlerCandidate and
         exists(
           DataFlow::Node input, TypeTrackingPseudoProperty key, CollectionFlowStep store,
           CollectionFlowStep load, DataFlow::Node storeTo, DataFlow::Node loadFrom

Original file line number	Diff line number	Diff line change
`@@ -661,7 +661,8 @@ module HTTP {`
`661`	`661`	`)`
`662`	`662`	`}`
`663`	`663`
`664`		`- override RouteHandlerCandidate getRouteHandler(DataFlow::SourceNode access) {`
	`664`	`+ override DataFlow::SourceNode getRouteHandler(DataFlow::SourceNode access) {`
	`665`	`+ result instanceof RouteHandlerCandidate and`
`665`	`666`	`exists(`
`666`	`667`	`DataFlow::Node input, TypeTrackingPseudoProperty key, CollectionFlowStep store,`
`667`	`668`	`CollectionFlowStep load, DataFlow::Node storeTo, DataFlow::Node loadFrom`