C++: Make PartialDefinitionNode private

jbj · jbj · commit ef9628830312 · 2019-09-09T10:34:51.000+02:00
This class is undocumented and exposes implementation details through
its `getPartialDefinition` member. It does not need to be public.
diff --git a/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowUtil.qll b/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowUtil.qll
@@ -268,7 +268,7 @@ abstract class PostUpdateNode extends Node {
   override Location getLocation() { result = getPreUpdateNode().getLocation() }
 }
 
-class PartialDefinitionNode extends PostUpdateNode, TPartialDefinitionNode {
+private class PartialDefinitionNode extends PostUpdateNode, TPartialDefinitionNode {
   PartialDefinition pd;
 
   PartialDefinitionNode() { this = TPartialDefinitionNode(pd) }

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ abstract class PostUpdateNode extends Node {`
`268`	`268`	`override Location getLocation() { result = getPreUpdateNode().getLocation() }`
`269`	`269`	`}`
`270`	`270`
`271`		`-class PartialDefinitionNode extends PostUpdateNode, TPartialDefinitionNode {`
	`271`	`+private class PartialDefinitionNode extends PostUpdateNode, TPartialDefinitionNode {`
`272`	`272`	`PartialDefinition pd;`
`273`	`273`
`274`	`274`	`PartialDefinitionNode() { this = TPartialDefinitionNode(pd) }`